[GitHub] [pulsar] sijie edited a comment on issue #6791: Use consistent hashing in KeyShared distribution

[GitBox <gi...@apache.org>]

sijie edited a comment on issue #6791:
URL: https://github.com/apache/pulsar/pull/6791#issuecomment-618267027


   > The current implementation is severely broken. This PR is fixing the bug. I don't see an easy way to fix it based on the splitting range design.
   
   I see there is a problem in the current algorithm when scaling down the number of consumers. But I don't think its broken. In most of the production, people usually don't scale down the number of consumers. They usually scale up the number of consumers. So the extreme case you described in the description probably wasn't really noticed. This is the caveat of the current algorithm. We can find ways to improve it or other people in the community can find a way to improve it.
   
   If you have a better algorithm to resolve the key distribution and the screw problem during split-and-merge, that's great and the community is excited about it. Then let's introduce that algorithm. This allows people to slowly migrate to a new algorithm and fall back as needed. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org