[GitHub] spark pull request #18499: [SPARK-21176][WEB UI] Use a single ProxyServlet t...

[gengliangwang <gi...@git.apache.org>]

Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18499#discussion_r131119963
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -194,30 +194,26 @@ private[spark] object JettyUtils extends Logging {
       }
     
       /** Create a handler for proxying request to Workers and Application Drivers */
    -  def createProxyHandler(
    -      prefix: String,
    -      target: String): ServletContextHandler = {
    +  def createProxyHandler(idToUiAddress: String => Option[String]): ServletContextHandler = {
         val servlet = new ProxyServlet {
           override def rewriteTarget(request: HttpServletRequest): String = {
    -        val rewrittenURI = createProxyURI(
    -          prefix, target, request.getRequestURI(), request.getQueryString())
    -        if (rewrittenURI == null) {
    -          return null
    -        }
    -        if (!validateDestination(rewrittenURI.getHost(), rewrittenURI.getPort())) {
    -          return null
    -        }
    -        rewrittenURI.toString()
    +        val path = request.getPathInfo
    +        if (path == null) return null
    +
    +        val prefixTrailingSlashIndex = path.indexOf('/', 1)
    +        val prefix = path.substring(0,
    +          if (prefixTrailingSlashIndex == -1) path.length else prefixTrailingSlashIndex)
    --- End diff --
    
    I think we can save use a variable to save the second parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org