[GitHub] tornadomeet commented on a change in pull request #7421: Resolve more compile warnings

[gi...@git.apache.org]

tornadomeet commented on a change in pull request #7421: Resolve more compile warnings
URL: https://github.com/apache/incubator-mxnet/pull/7421#discussion_r135161813
 
 

 ##########
 File path: src/operator/bilinear_sampler.cc
 ##########
 @@ -28,7 +28,7 @@
 namespace mshadow {
 template<typename DType>
 bool between(DType value, int lowerBound, int upperBound) {
-  return (value >= lowerBound && value <= upperBound);
+  return (static_cast<int>(value) >= lowerBound && static_cast<int>(value) <= upperBound);
 
 Review comment:
   DType should be a real number, so it is float
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services