You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2025/05/01 15:59:33 UTC
[PR] Add TIs tab to mapped task details [airflow]
bbovenzi opened a new pull request, #50085:
URL: https://github.com/apache/airflow/pull/50085
Add `Task Instances [{map_index}]` tab to a mapped task's detail page. This makes it easier to switch between mapped tasks to see logs, xcoms, etc
Closes https://github.com/apache/airflow/issues/34489
<img width="1011" alt="Screenshot 2025-05-01 at 11 57 26 AM" src="https://github.com/user-attachments/assets/e5edb793-3a04-46b9-b115-bc80d60c0f6b" />
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TIs tab to mapped task details [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #50085:
URL: https://github.com/apache/airflow/pull/50085#issuecomment-2845138338
One question I have. Should the number in the tab should be the total count of mapped tasks or the rendered_map_index of the selected mapped TI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TIs tab to mapped task details [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #50085:
URL: https://github.com/apache/airflow/pull/50085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TIs tab to mapped task details [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #50085:
URL: https://github.com/apache/airflow/pull/50085#issuecomment-2845639441
> One question I have. Should the number in the tab should be the total count of mapped tasks or the rendered_map_index of the selected mapped TI?
The map index is actually redundant to the breadcrumb. So actually you could remove it.
Alternative you can also display it as `9/32` so you have the total number and the individual index?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TIs tab to mapped task details [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #50085:
URL: https://github.com/apache/airflow/pull/50085#issuecomment-2847385314
> Looks good.
>
> Have you considered (as you are on this) to also support a direct "prev"/"next" navigation button, such that you don't need to click on the list to find the next but you can direct jump from 9 to 10? e.g. like a `< 9/32 >`?
Playing around with the numbers wasn't great since map_index starts at 0, and we use `rendered_map_index` in many places so we can't rely on it being a number. Instead, I am keeping the tab consistent with the total mapped TI count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TIs tab to mapped task details [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #50085:
URL: https://github.com/apache/airflow/pull/50085#issuecomment-2847372875
> Looks good.
>
> Have you considered (as you are on this) to also support a direct "prev"/"next" navigation button, such that you don't need to click on the list to find the next but you can direct jump from 9 to 10? e.g. like a `< 9/32 >`?
Thats a good idea. I'd definitely like to add more quick nav options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org