You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "Arsnael (via GitHub)" <gi...@apache.org> on 2023/08/01 08:38:13 UTC
[GitHub] [james-project] Arsnael opened a new pull request, #1663: JAMES-3933 BasicAuthenticationStrategy should throw a proper error message when invalid credentials
Arsnael opened a new pull request, #1663:
URL: https://github.com/apache/james-project/pull/1663
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1663: JAMES-3933 BasicAuthenticationStrategy should throw a proper error message when invalid credentials
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #1663:
URL: https://github.com/apache/james-project/pull/1663#discussion_r1280353796
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/http/BasicAuthenticationStrategy.scala:
##########
@@ -129,7 +128,9 @@ class BasicAuthenticationStrategy @Inject()(val usersRepository: UsersRepository
private def publishNext[T]: (Option[T], reactor.core.publisher.SynchronousSink[T]) => Unit =
(maybeT, sink) => maybeT.foreach(t => sink.next(t))
- private def getAuthenticatedUsername(userCredential: UserCredential): SMono[Option[Username]] =
- SMono.fromCallable(() => usersRepository.test(userCredential.username, userCredential.password).toScala)
+ private def getAuthenticatedUsername(userCredential: UserCredential): SMono[Username] =
+ SMono.fromCallable(() => usersRepository.test(userCredential.username, userCredential.password)
+ .toScala
Review Comment:
```suggestion
```
No need anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael merged pull request #1663: JAMES-3933 BasicAuthenticationStrategy should throw a proper error message when invalid credentials
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael merged PR #1663:
URL: https://github.com/apache/james-project/pull/1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org