You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2023/01/11 15:18:00 UTC

[GitHub] [incubator-tuweni] gezero opened a new pull request, #487: Adding support for encoding and decoding of complex SSZ types

gezero opened a new pull request, #487:
URL: https://github.com/apache/incubator-tuweni/pull/487

   * Added support for Containers
   * Added support for generic lists of fixed/variable size type
   * Added support for generic fixed size type vectors
   
   I had to add some handling of scopes (SSZReader.slice()) and also some type hierarchy. Let me try to justify why
   
   * The size of the list of variable size type is easy to calculate from the first offset, because the fixed part of encoding only contains offsets.
   
   * The size of a vector is known at the time of designing the data structure.
   
   * But the size of the list when reading a list of fixed size type is not encoded. To find out what the size is, one must carefully maintain the scopes and then divide the corresponding scope of the list by the size of one element (size of one element is known at the time of defining the data structure).
   
   * Moreover The length of a scope for a list is unknown until we read the offset of the next variable element in the parent container or the reminder of the fixed part.
   
   Signed-off-by: Jiri Peinlich <ji...@gmail.com>
   
   <!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
   <!-- https://github.com/apache/incubator-tuweni/blob/main/CONTRIBUTING.md -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] gezero commented on pull request #487: Adding support for encoding and decoding of complex SSZ types

Posted by GitBox <gi...@apache.org>.
gezero commented on PR #487:
URL: https://github.com/apache/incubator-tuweni/pull/487#issuecomment-1379013364

   Any advice how to add licence to an arbitrary file that I read during a test? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme merged pull request #487: Adding support for encoding and decoding of complex SSZ types

Posted by GitBox <gi...@apache.org>.
atoulme merged PR #487:
URL: https://github.com/apache/incubator-tuweni/pull/487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org


[GitHub] [incubator-tuweni] atoulme commented on pull request #487: Adding support for encoding and decoding of complex SSZ types

Posted by GitBox <gi...@apache.org>.
atoulme commented on PR #487:
URL: https://github.com/apache/incubator-tuweni/pull/487#issuecomment-1379995992

   you can add it to the rat excludes in build.gradle. See here: https://github.com/apache/incubator-tuweni/blob/main/build.gradle#L102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org