You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/09 03:31:58 UTC
[GitHub] [rocketmq-client-go] kallydev opened a new pull request #700: [ISSUE #637] Fix filter lookback interface for utils.ClientIP
kallydev opened a new pull request #700:
URL: https://github.com/apache/rocketmq-client-go/pull/700
## What is the purpose of the change
Resolved #637.
## Brief changelog
By filtering the loopback type and the non-up state of the interface, we can get a correct and available client IP.
## Verifying this change
```bash
go test -v internal/utils/net.go internal/utils/net_test.go
```
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter edited a comment on pull request #700: [ISSUE #637] Fix filter lookback interface for utils.ClientIP
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #700:
URL: https://github.com/apache/rocketmq-client-go/pull/700#issuecomment-876887403
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#700](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6ab883) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/8612bf76869222a16bc1c55838f15aba1ad24dd2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8612bf7) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 25.20% 25.25% +0.05%
==========================================
Files 48 48
Lines 5269 5270 +1
==========================================
+ Hits 1328 1331 +3
+ Misses 3733 3732 -1
+ Partials 208 207 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/utils/net.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/700/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdXRpbHMvbmV0Lmdv) | `52.94% <100.00%> (+15.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8612bf7...b6ab883](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai merged pull request #700: [ISSUE #637] Fix filter lookback interface for utils.ClientIP
Posted by GitBox <gi...@apache.org>.
maixiaohai merged pull request #700:
URL: https://github.com/apache/rocketmq-client-go/pull/700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #700: [ISSUE #637] Fix filter lookback interface for utils.ClientIP
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #700:
URL: https://github.com/apache/rocketmq-client-go/pull/700#issuecomment-876887403
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#700](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6ab883) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/8612bf76869222a16bc1c55838f15aba1ad24dd2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8612bf7) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #700 +/- ##
==========================================
+ Coverage 25.20% 25.25% +0.05%
==========================================
Files 48 48
Lines 5269 5270 +1
==========================================
+ Hits 1328 1331 +3
+ Misses 3733 3732 -1
+ Partials 208 207 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/utils/net.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/700/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdXRpbHMvbmV0Lmdv) | `52.94% <100.00%> (+15.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8612bf7...b6ab883](https://codecov.io/gh/apache/rocketmq-client-go/pull/700?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on pull request #700: [ISSUE #637] Fix filter lookback interface for utils.ClientIP
Posted by GitBox <gi...@apache.org>.
maixiaohai commented on pull request #700:
URL: https://github.com/apache/rocketmq-client-go/pull/700#issuecomment-878781999
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #700: [ISSUE #637] Fix filter lookback interface for utils.ClientIP
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #700:
URL: https://github.com/apache/rocketmq-client-go/pull/700#issuecomment-878037171
LGTM @maixiaohai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org