You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/10 08:12:27 UTC
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #563: [YUNIKORN-1610] Enforcement changes for User Based Quota
codecov[bot] commented on PR #563:
URL: https://github.com/apache/yunikorn-core/pull/563#issuecomment-1585556692
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#563](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3b9fbd9) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/8febe293312f74c4af5000ba8858fb0821772b2a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8febe29) will **decrease** coverage by `0.18%`.
> The diff coverage is `64.21%`.
```diff
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 74.84% 74.67% -0.18%
==========================================
Files 71 73 +2
Lines 11537 12074 +537
==========================================
+ Hits 8635 9016 +381
- Misses 2597 2726 +129
- Partials 305 332 +27
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `76.87% <ø> (-0.02%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `79.79% <ø> (ø)` | |
| [pkg/scheduler/partition.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `76.60% <25.00%> (-0.64%)` | :arrow_down: |
| [pkg/scheduler/ugm/manager.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci91Z20vbWFuYWdlci5nbw==) | `55.95% <49.14%> (-2.95%)` | :arrow_down: |
| [pkg/common/configs/configvalidator.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `88.76% <87.50%> (-0.29%)` | :arrow_down: |
| [pkg/scheduler/ugm/queue\_tracker.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci91Z20vcXVldWVfdHJhY2tlci5nbw==) | `87.17% <93.67%> (+5.73%)` | :arrow_up: |
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `65.38% <100.00%> (+0.85%)` | :arrow_up: |
| [pkg/scheduler/ugm/group\_tracker.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci91Z20vZ3JvdXBfdHJhY2tlci5nbw==) | `100.00% <100.00%> (ø)` | |
| [pkg/scheduler/ugm/user\_tracker.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci91Z20vdXNlcl90cmFja2VyLmdv) | `100.00% <100.00%> (ø)` | |
| [pkg/scheduler/ugm/utilities.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci91Z20vdXRpbGl0aWVzLmdv) | `100.00% <100.00%> (ø)` | |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/563/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org