[jira] [Commented] (MAPREDUCE-6499) Add More Informations Of Jobs In JobHistory Main Page

["Akira AJISAKA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985337#comment-14985337 ] 

Akira AJISAKA commented on MAPREDUCE-6499:
------------------------------------------

Mostly looks good to me. Two comments.
{code}
              String.valueOf(secToTime((job.getFinishTime() - job
                  .getStartTime()) / 1000))).append("\"],\n");
{code}
1. Can we reuse the implementation of {{StringUtils.formatTime}}? The implementation is simpler.
{code}
  private String unitFormat(long i)
{code}
2. The method can be replaced by {{String.format("%02d", i)}}.

Now I'm +1 for "hh:mm:ss" format for elapsed time because it's sortable by datatable.js and the time unit is clear.

> Add More Informations Of Jobs In JobHistory Main Page
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-6499
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6499
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.7.1
>            Reporter: Lin Yiqun
>            Assignee: Lin Yiqun
>            Priority: Trivial
>         Attachments: HADOOP-MAPREDUCE-6499.2.patch, HADOOP-MAPREDUCE-6499.3.patch, HADOOP-MAPREDUCE-6499.4.patch, HADOOP-MAPREDUCE-6499.5.patch, HADOOP-MAPREDUCE-6499.6.patch, HADOOP-MAPREDUCE-6499.patch
>
>
> Now in  JobHistory Main Page show too little information about finished jobs,even don't have the job's running total time,only startTime,finishedTime.So,in jobHistory main page,we can add more informations about jobs, that we can better analyze jobs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)