You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/06/15 05:08:54 UTC
[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/5
GUACAMOLE-52: Document changes to history table schema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-manual update-history-schema
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit d277ba07ab12e57a4da322c854e7fc4b26091735
Author: Michael Jumper <mj...@apache.org>
Date: 2016-06-15T05:06:19Z
GUACAMOLE-52: Document history table username/connection_name columns and foreign key behavior.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/5#discussion_r67101330
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -839,15 +839,32 @@ INSERT INTO guacamole_connection_parameter VALUES (<replaceable>1</replaceable>,
<listitem>
<para>The value of the <property>user_id</property> from the entry in
<classname>guacamole_user</classname> associated with the user
- using the connection.</para>
+ using the connection. If the user no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>username</property></term>
+ <listitem>
+ <para>The unique name associated with the user at the time that they
+ used the connection.</para>
</listitem>
</varlistentry>
<varlistentry>
<term><property>connection_id</property></term>
<listitem>
<para>The value of the <property>connection_id</property> from the entry
in <classname>guacamole_connection</classname> associated the
- connection being used.</para>
+ connection being used. If the connection associated with the history
+ record no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>connection_name</property></term>
+ <listitem>
+ <para>The unique name associated with the connection at the time that it
--- End diff --
Yup. It isn't necessarily unique in the API, but it is in the schema, and that's enforced by a constraint.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/5#discussion_r67101184
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -839,15 +839,32 @@ INSERT INTO guacamole_connection_parameter VALUES (<replaceable>1</replaceable>,
<listitem>
<para>The value of the <property>user_id</property> from the entry in
<classname>guacamole_user</classname> associated with the user
- using the connection.</para>
+ using the connection. If the user no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>username</property></term>
+ <listitem>
+ <para>The unique name associated with the user at the time that they
+ used the connection.</para>
</listitem>
</varlistentry>
<varlistentry>
<term><property>connection_id</property></term>
<listitem>
<para>The value of the <property>connection_id</property> from the entry
in <classname>guacamole_connection</classname> associated the
- connection being used.</para>
+ connection being used. If the connection associated with the history
+ record no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>connection_name</property></term>
+ <listitem>
+ <para>The unique name associated with the connection at the time that it
--- End diff --
Is the connection name actually unique?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/5#discussion_r67101573
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -839,15 +839,32 @@ INSERT INTO guacamole_connection_parameter VALUES (<replaceable>1</replaceable>,
<listitem>
<para>The value of the <property>user_id</property> from the entry in
<classname>guacamole_user</classname> associated with the user
- using the connection.</para>
+ using the connection. If the user no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>username</property></term>
+ <listitem>
+ <para>The unique name associated with the user at the time that they
+ used the connection.</para>
</listitem>
</varlistentry>
<varlistentry>
<term><property>connection_id</property></term>
<listitem>
<para>The value of the <property>connection_id</property> from the entry
in <classname>guacamole_connection</classname> associated the
- connection being used.</para>
+ connection being used. If the connection associated with the history
+ record no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>connection_name</property></term>
+ <listitem>
+ <para>The unique name associated with the connection at the time that it
--- End diff --
Well it's not globally unique right? Only within the parent connection group.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-manual pull request #5: GUACAMOLE-52: Document changes t...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-manual/pull/5#discussion_r67101660
--- Diff: src/chapters/jdbc-auth.xml ---
@@ -839,15 +839,32 @@ INSERT INTO guacamole_connection_parameter VALUES (<replaceable>1</replaceable>,
<listitem>
<para>The value of the <property>user_id</property> from the entry in
<classname>guacamole_user</classname> associated with the user
- using the connection.</para>
+ using the connection. If the user no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>username</property></term>
+ <listitem>
+ <para>The unique name associated with the user at the time that they
+ used the connection.</para>
</listitem>
</varlistentry>
<varlistentry>
<term><property>connection_id</property></term>
<listitem>
<para>The value of the <property>connection_id</property> from the entry
in <classname>guacamole_connection</classname> associated the
- connection being used.</para>
+ connection being used. If the connection associated with the history
+ record no longer exists, this will be
+ <constant>NULL</constant>.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><property>connection_name</property></term>
+ <listitem>
+ <para>The unique name associated with the connection at the time that it
--- End diff --
True.
Very well. I shall document it ... *correctly*.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---