You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/30 02:56:40 UTC
[GitHub] [apisix] starsz opened a new issue #2569: CI: line is too line
starsz opened a new issue #2569:
URL: https://github.com/apache/apisix/issues/2569
Hi, while I am reading the code, I found that some lines are too long (More than eighty characters).
As the [CODE_STYLE.md](https://github.com/apache/apisix/blob/master/CODE_STYLE.md#maximum-length-per-line) said.
> Each line cannot exceed 80 characters. If it exceeds, you need to wrap and align:
I recommend adding `--max-line-length 80` into luacheck, and fix all the lines exceed 80 characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] idbeta commented on issue #2569: CI: line is too line
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #2569:
URL: https://github.com/apache/apisix/issues/2569#issuecomment-719143124
I agree that 80 characters are enough most of the time, but sometimes 80 characters seem a little bit short and make the code more awkward to read, just for python.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #2569: CI: line is too line
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #2569:
URL: https://github.com/apache/apisix/issues/2569#issuecomment-719144786
The specification of 80 characters forces programmer to design concise variable name, function name and literals, I don't think it makes the code more awkward to read (if so, community can refactor it :) ), so i think we should obey the code style specification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2569: CI: line is too line
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2569:
URL: https://github.com/apache/apisix/issues/2569#issuecomment-719386887
> The length we chose is 100.
I think `100` is fine.
https://github.com/apache/apisix/blob/master/.luacheckrc#L4
we checked it by `luacheck` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis closed issue #2569: CI: line is too line
Posted by GitBox <gi...@apache.org>.
membphis closed issue #2569:
URL: https://github.com/apache/apisix/issues/2569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on issue #2569: CI: line is too line
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #2569:
URL: https://github.com/apache/apisix/issues/2569#issuecomment-719149362
Okay, I follow the decision of the community. Hmmm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2569: CI: line is too line
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2569:
URL: https://github.com/apache/apisix/issues/2569#issuecomment-719145762
@starsz
Currently we already have the line length style check in `lj-releng`. The length we chose is 100.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org