[GitHub] [ozone] neils-dev commented on pull request #2518: HDDS-5358. Intermittent failure in testGetS3SecretAndRevokeS3Secret

[GitBox <gi...@apache.org>]

neils-dev commented on pull request #2518:
URL: https://github.com/apache/ozone/pull/2518#issuecomment-896502861


   Thanks @bharatviswa504 for review and comments. Thanks @adoroszlai for spotting the error in invalidating the cache entry.  Have updated commit with invaliding correct cache in revoke.
   
   Q. In the S3RevokeSecretRequest, incorrectly trying to strike the s3 secret from the cache would **ensure** that the s3 key **exists** in the s3 secret cache.  Any subsequent 'get' or 'lookup' for the s3 key would then always 'hit' and retrieve the s3 key the user revoked.  How are we observing intermittent errors in this case?  Would the s3 secret integration test always fail then?  Does the batch delete from the s3 table somehow **also** invalid the cache in the doubleuffer thread in background - thus intermittent failure observed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org