You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/21 14:09:16 UTC
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 2:09 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Summary (updated)
-----------------
Added '/state-summary' to the set of batched master endpoints.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description (updated)
-------
Added '/state-summary' to the set of batched master endpoints.
Diffs (updated)
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
Diff: https://reviews.apache.org/r/68321/diff/3/
Changes: https://reviews.apache.org/r/68321/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 10:27 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Changes
-------
Rebased onto latest master.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
Added '/state-summary' to the set of batched master endpoints.
Diffs (updated)
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
Diff: https://reviews.apache.org/r/68321/diff/4/
Changes: https://reviews.apache.org/r/68321/diff/3-4/
Testing
-------
See https://reviews.apache.org/r/68473/
Thanks,
Benno Evers
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 10:06 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
Added '/state-summary' to the set of batched master endpoints.
Diffs
-----
src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
Diff: https://reviews.apache.org/r/68321/diff/3/
Testing (updated)
-------
https://reviews.apache.org/r/68473/
Thanks,
Benno Evers
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Benno Evers <be...@mesosphere.com>.
> On Aug. 27, 2018, 11:19 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 3476 (original), 3487 (patched)
> > <https://reviews.apache.org/r/68321/diff/3/?file=2075651#file2075651line3487>
> >
> > `return std::move(OK(...));`
Dropping this since we agreed in offline discussions that it would not make a difference.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207956
-----------------------------------------------------------
On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 2:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/state-summary' to the set of batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
>
>
> Diff: https://reviews.apache.org/r/68321/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68321: Added '/state-summary' to the set of batched
master endpoints.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207956
-----------------------------------------------------------
Fix it, then Ship it!
Looks good to me (modulo testing).
src/master/http.cpp
Line 3476 (original), 3487 (patched)
<https://reviews.apache.org/r/68321/#comment291623>
`return std::move(OK(...));`
- Alexander Rukletsov
On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 2:09 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '/state-summary' to the set of batched master endpoints.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
>
>
> Diff: https://reviews.apache.org/r/68321/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>