You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/10/22 20:31:58 UTC
[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6176: Merge common APIs for Dictionary
chenboat commented on a change in pull request #6176:
URL: https://github.com/apache/incubator-pinot/pull/6176#discussion_r510438874
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/Dictionary.java
##########
@@ -40,14 +42,52 @@
*/
DataType getValueType();
+ /**
+ * Returns the number of values in the dictionary.
+ */
int length();
/**
* Returns the index of the string representation of the value in the dictionary, or {@link #NULL_VALUE_INDEX} (-1) if
- * the value does not exist. This API is for cross-type predicate evaluation.
+ * the value does not exist. This method is for the cross-type predicate evaluation.
*/
int indexOf(String stringValue);
+ /**
+ * Returns the insertion index of the string representation of the value in the dictionary. This method follows the
+ * same behavior as in {@link Arrays#binarySearch(Object[], Object)}. All sorted dictionary should support this
+ * method. This method is for the range predicate evaluation.
+ */
+ int insertionIndexOf(String stringValue);
+
+ /**
+ * Returns a set of dictIds in the given value range, where lower/upper bound can be "*" which indicates unbounded
Review comment:
is the range inclusive or exclusive the in lower and upper bounds?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org