You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "walklown (via GitHub)" <gi...@apache.org> on 2024/03/22 08:08:22 UTC
[PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
walklown opened a new pull request, #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110
Upgrade all use cases in the '2-advance' directory to spring-boot 3.x, jdk 17. Effect 114 files. Passed all tests. If it is not allowed to affect so much, then I can also give up my PR. @chickenlj
https://github.com/apache/dubbo/issues/13862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535240050
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
no need to add this dependency here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "walklown (via GitHub)" <gi...@apache.org>.
walklown commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535252138
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
This determines the version of the ‘org.apache.maven.plugins’ plugin. I understand that the versions of these plugins should be unified. Or do you suggest that the versions of the plug-ins should be defined in the pom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "walklown (via GitHub)" <gi...@apache.org>.
walklown commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535259906
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
Some original poms use this parent pom to determine the version of plugins, while others specify the version directly. The dubbo project itself is specified through the parent pom, so this method is currently used.
Actually I don't mind which one to use, but it is recommended to unify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "walklown (via GitHub)" <gi...@apache.org>.
walklown commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1540516941
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
I think I've said it more clearly, and I have no idea why I didn't get a follow-up reply. Then I decided to give up this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536772943
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
I don't understand why we need to add this dependency when the following has already been set as the parent of the demo project:
```xml
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>31</version>
<relativePath/>
</parent>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "walklown (via GitHub)" <gi...@apache.org>.
walklown commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536997259
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
1、The 'root pom.xml' and the '1-basic/pom.xml' does not set this parent. Maybe in diffrent branch ?
2、The project structure of the current project is split. For example, 'root pom.xml' sets '1-basic/pom.xml' as module, but '1-basic/pom.xml' does not set 'root pom.xml' as parent. Therefore, the component versions in '1-basic/pom.xml' and subordinate pom.xml are not controlled by 'root pom.xml'.
And the parent of 'dubbo-samples-spring-boot-idl/dubbo-samples-spring-boot-idl-provider/pom.xml' is set to 'dubbo-samples-spring-boot-idl/pom.xml', so dubbo -samples-spring-boot-idl The component versions of this subproject are controlled by 'dubbo-samples-spring-boot-idl/pom.xml'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "walklown (via GitHub)" <gi...@apache.org>.
walklown commented on code in PR #1110:
URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1537001318
##########
1-basic/dubbo-samples-spring-boot-idl/pom.xml:
##########
@@ -53,6 +53,13 @@
<dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>org.apache</groupId>
+ <artifactId>apache</artifactId>
+ <version>31</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
Review Comment:
Means 'apache -> dubbo-samples-spring-boot-idl -> dubbo-samples-spring-boot-idl-provider/consumer', not 'root -> 1-basic -> dubbo-samples-spring-boot-idl -> dubbo-samples-spring-boot-idl-provider/consumer'.
'modules' tag only works for 'The Reactor' of maven.
https://maven.apache.org/guides/mini/guide-multiple-modules.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]
Posted by "walklown (via GitHub)" <gi...@apache.org>.
walklown closed pull request #1110: Bump apache parent to 31, jdk to 17 and springboot to 3.2.3
URL: https://github.com/apache/dubbo-samples/pull/1110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org