You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2024/02/19 23:48:57 UTC

(causeway) 01/03: CAUSEWAY-3676: replaces Map of params with a simple List

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch CAUSEWAY-3676
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit f13e67a26e29ecb4a7a0eb1fad5f0d20bc11a08c
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Mon Feb 19 20:03:37 2024 +0000

    CAUSEWAY-3676: replaces Map of params with a simple List
---
 .../causeway/viewer/graphql/model/domain/GqlvActionParams.java    | 8 +++++---
 .../viewer/graphql/model/domain/GqlvActionParamsParamHidden.java  | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParams.java b/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParams.java
index d127a90b48..028cb60644 100644
--- a/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParams.java
+++ b/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParams.java
@@ -18,7 +18,9 @@
  */
 package org.apache.causeway.viewer.graphql.model.domain;
 
+import java.util.ArrayList;
 import java.util.LinkedHashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicInteger;
 
@@ -47,7 +49,7 @@ public class GqlvActionParams
 
     @Getter private final Holder holder;
 
-    private final Map<String, GqlvActionParamsParam> params = new LinkedHashMap<>();
+    private final List<GqlvActionParamsParam> params = new ArrayList<>();
 
     public GqlvActionParams(
             final Holder holder,
@@ -64,7 +66,7 @@ public class GqlvActionParams
         holder.getObjectAction().getParameters().forEach(objectActionParameter -> {
             val gqlvActionParam = new GqlvActionParamsParam(this, objectActionParameter, this.context, idx.getAndIncrement());
             addChildFieldFor(gqlvActionParam);
-            params.put(objectActionParameter.getId(), gqlvActionParam);
+            params.add(gqlvActionParam);
         });
 
         if (hasParams()) {
@@ -93,7 +95,7 @@ public class GqlvActionParams
 
     @Override
     protected void addDataFetchersForChildren() {
-        params.forEach((id, param) -> param.addDataFetcher(this));
+        params.forEach(param -> param.addDataFetcher(this));
     }
 
 
diff --git a/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParamsParamHidden.java b/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParamsParamHidden.java
index 4d48af0fca..c6937285dd 100644
--- a/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParamsParamHidden.java
+++ b/viewers/graphql/model/src/main/java/org/apache/causeway/viewer/graphql/model/domain/GqlvActionParamsParamHidden.java
@@ -52,7 +52,7 @@ public class GqlvActionParamsParamHidden extends GqlvAbstract {
 
         GraphQLFieldDefinition.Builder fieldBuilder = newFieldDefinition()
                 .name("hidden")
-                .type((GraphQLOutputType) context.typeMapper.outputTypeFor(boolean.class));
+                .type(context.typeMapper.outputTypeFor(boolean.class));
         holder.addGqlArguments(holder.getObjectAction(), fieldBuilder, TypeMapper.InputContext.DISABLE, holder.getParamNum());
         setField(fieldBuilder.build());
     }