You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/07 08:30:19 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9991: [fix] (planner) passthrough child in SetOperationNode is wrong when enable vectorized engine
morrySnow opened a new pull request, #9991:
URL: https://github.com/apache/incubator-doris/pull/9991
# Proposed changes
Issue Number: close #9952
## Problem Summary:
In SetOperationNode we do passthrough, if we child output is same with itself output. In method `isChildPassthrough` we only consider memory layout. When we use vectorized engine, we need to use SlotDesc offset in TupleDesc instead of memory layout to check whether pass-through can be performed
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back:No
## Further comments
Add UT and regression-test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9991: [fix] (planner) passthrough child in SetOperationNode is wrong when enable vectorized engine
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9991:
URL: https://github.com/apache/incubator-doris/pull/9991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9991: [fix] (planner) passthrough child in SetOperationNode is wrong when enable vectorized engine
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9991:
URL: https://github.com/apache/incubator-doris/pull/9991#issuecomment-1148375036
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9991: [fix] (planner) passthrough child in SetOperationNode is wrong when enable vectorized engine
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9991:
URL: https://github.com/apache/incubator-doris/pull/9991#issuecomment-1148374994
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org