You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by nicolas de loof <ni...@apache.org> on 2009/05/13 13:53:11 UTC

Checkstyle plugin - upgrade to checkstyle 5 ?

Hi
You may have noticed discussion on user list about checkstyle plugin to
upgrade to checkstyle 5.
(http://jira.codehaus.org/browse/MCHECKSTYLE-105)<http://jira.codehaus.org/browse/MCHECKSTYLE-105>

Such upgrade would require Java5 as plugin runtime.
What's the best option here ?

- upgrade maven-checstyle-plugin to checkstyle 5 in 2.3
- release 2.3 with few changes from 2.2 (june 2008) and upgrade to
checkstyle 5 for 2.4 (or 3.0) branch

I can't see a significant change since 2.2 release (see following log). For
this reason I'd like to apply MCHECKSTYLE-105
<http://jira.codehaus.org/browse/MCHECKSTYLE-105>to
trunk.

What's your opinion ?

Nicolas


Here is the commit log for the plugin since 2.2 release :

Revision: 680642
Author: bentmann
Date: 09:54:33, mardi 29 juillet 2008
Message:
o Excluded some more not so magic numbers
----

Revision: 682367
Author: aheritier
Date: 14:47:41, lundi 4 août 2008
Message:
Try to use the 12-SNAPSHOT parent
----

Revision: 683667
Author: bentmann
Date: 20:08:15, jeudi 7 août 2008
Message:
o Added stub IT profile to highlight plugins during CI
----

Revision: 684868
Author: bentmann
Date: 20:43:53, lundi 11 août 2008
Message:
o Reordered POM
----

Revision: 684869
Author: bentmann
Date: 20:45:29, lundi 11 août 2008
Message:
o Added project description
----

Revision: 684879
Author: bentmann
Date: 21:06:46, lundi 11 août 2008
Message:
o Added some integration tests
----

Revision: 686066
Author: bentmann
Date: 00:21:48, vendredi 15 août 2008
Message:
o Added ASF snapshot repo to user settings of ITs (e.g. to make sure they
can resolve snapshot parents)
----

Revision: 689012
Author: bentmann
Date: 11:57:03, mardi 26 août 2008
Message:
o Updated index page of plugin site
----

Revision: 689057
Author: bentmann
Date: 15:01:43, mardi 26 août 2008
Message:
o Unified plugin name
----

Revision: 689071
Author: bentmann
Date: 15:36:10, mardi 26 août 2008
Message:
o Changed encoding of site descriptor to UTF-8 just like used for POMs
o Updated/added license headers
----

Revision: 689890
Author: bentmann
Date: 18:56:51, jeudi 28 août 2008
Message:
o Explicitly stated UTF-8 as file encoding
o Updated license header
----

Revision: 690250
Author: bentmann
Date: 15:27:05, vendredi 29 août 2008
Message:
o Updated index page of plugin site
----

Revision: 697604
Author: bentmann
Date: 22:41:41, dimanche 21 septembre 2008
Message:
o Inherited from maven-plugins:12
----

Revision: 697617
Author: bentmann
Date: 23:30:37, dimanche 21 septembre 2008
Message:
o Formatted/reordered POM
----

Revision: 697620
Author: bentmann
Date: 23:32:44, dimanche 21 septembre 2008
Message:
o Removed inherited stuff
----

Revision: 703806
Author: hboutemy
Date: 14:19:23, dimanche 12 octobre 2008
Message:
avoid warnings during unit-tests because encoding parameter not set
----

Revision: 712554
Author: hboutemy
Date: 22:08:42, dimanche 9 novembre 2008
Message:
upgrade plexus-utils to 1.5.6
----

Revision: 728331
Author: bentmann
Date: 19:48:54, samedi 20 décembre 2008
Message:
o Updated all plugins to use maven-invoker-plugin:1.3 to workaround MNG-3284
and bogus CI failures
----

Revision: 728432
Author: bentmann
Date: 13:29:50, dimanche 21 décembre 2008
Message:
o Adjusted IT settings to compensate for the unusual unix-style local repo
path used on the Windows nodes of the Hudson grid
----


Revision: 728546
Author: bentmann
Date: 23:56:51, dimanche 21 décembre 2008
Message:
o Fixed svn:keywords
----

Revision: 731252
Author: bentmann
Date: 14:11:57, dimanche 4 janvier 2009
Message:
o Avoided deprecated syntax @parameter expression="${component...}"
----

Revision: 745196
Author: brianf
Date: 20:16:04, mardi 17 février 2009
Message:
use the latest parents
----

Revision: 746480
Author: bentmann
Date: 11:24:49, samedi 21 février 2009
Message:
o Inherited from maven-plugins:13
----

Revision: 751080
Author: hboutemy
Date: 22:36:09, vendredi 6 mars 2009
Message:
used http://maven.apache.org/xsd/* for schema location
----

Re: Checkstyle plugin - upgrade to checkstyle 5 ?

Posted by Dennis Lundberg <de...@apache.org>.
We should have a policy discussion about the use of Java 5 in our
plugins. I will start another thread for that.

Your question here about the Checkstyle Plugin depends on the outcome of
the policy discussion.

nicolas de loof wrote:
> Hi
> You may have noticed discussion on user list about checkstyle plugin to
> upgrade to checkstyle 5.
> (http://jira.codehaus.org/browse/MCHECKSTYLE-105)<http://jira.codehaus.org/browse/MCHECKSTYLE-105>
> 
> Such upgrade would require Java5 as plugin runtime.
> What's the best option here ?
> 
> - upgrade maven-checstyle-plugin to checkstyle 5 in 2.3
> - release 2.3 with few changes from 2.2 (june 2008) and upgrade to
> checkstyle 5 for 2.4 (or 3.0) branch
> 
> I can't see a significant change since 2.2 release (see following log). For
> this reason I'd like to apply MCHECKSTYLE-105
> <http://jira.codehaus.org/browse/MCHECKSTYLE-105>to
> trunk.
> 
> What's your opinion ?
> 
> Nicolas
> 
> 
> Here is the commit log for the plugin since 2.2 release :
> 
> Revision: 680642
> Author: bentmann
> Date: 09:54:33, mardi 29 juillet 2008
> Message:
> o Excluded some more not so magic numbers
> ----
> 
> Revision: 682367
> Author: aheritier
> Date: 14:47:41, lundi 4 août 2008
> Message:
> Try to use the 12-SNAPSHOT parent
> ----
> 
> Revision: 683667
> Author: bentmann
> Date: 20:08:15, jeudi 7 août 2008
> Message:
> o Added stub IT profile to highlight plugins during CI
> ----
> 
> Revision: 684868
> Author: bentmann
> Date: 20:43:53, lundi 11 août 2008
> Message:
> o Reordered POM
> ----
> 
> Revision: 684869
> Author: bentmann
> Date: 20:45:29, lundi 11 août 2008
> Message:
> o Added project description
> ----
> 
> Revision: 684879
> Author: bentmann
> Date: 21:06:46, lundi 11 août 2008
> Message:
> o Added some integration tests
> ----
> 
> Revision: 686066
> Author: bentmann
> Date: 00:21:48, vendredi 15 août 2008
> Message:
> o Added ASF snapshot repo to user settings of ITs (e.g. to make sure they
> can resolve snapshot parents)
> ----
> 
> Revision: 689012
> Author: bentmann
> Date: 11:57:03, mardi 26 août 2008
> Message:
> o Updated index page of plugin site
> ----
> 
> Revision: 689057
> Author: bentmann
> Date: 15:01:43, mardi 26 août 2008
> Message:
> o Unified plugin name
> ----
> 
> Revision: 689071
> Author: bentmann
> Date: 15:36:10, mardi 26 août 2008
> Message:
> o Changed encoding of site descriptor to UTF-8 just like used for POMs
> o Updated/added license headers
> ----
> 
> Revision: 689890
> Author: bentmann
> Date: 18:56:51, jeudi 28 août 2008
> Message:
> o Explicitly stated UTF-8 as file encoding
> o Updated license header
> ----
> 
> Revision: 690250
> Author: bentmann
> Date: 15:27:05, vendredi 29 août 2008
> Message:
> o Updated index page of plugin site
> ----
> 
> Revision: 697604
> Author: bentmann
> Date: 22:41:41, dimanche 21 septembre 2008
> Message:
> o Inherited from maven-plugins:12
> ----
> 
> Revision: 697617
> Author: bentmann
> Date: 23:30:37, dimanche 21 septembre 2008
> Message:
> o Formatted/reordered POM
> ----
> 
> Revision: 697620
> Author: bentmann
> Date: 23:32:44, dimanche 21 septembre 2008
> Message:
> o Removed inherited stuff
> ----
> 
> Revision: 703806
> Author: hboutemy
> Date: 14:19:23, dimanche 12 octobre 2008
> Message:
> avoid warnings during unit-tests because encoding parameter not set
> ----
> 
> Revision: 712554
> Author: hboutemy
> Date: 22:08:42, dimanche 9 novembre 2008
> Message:
> upgrade plexus-utils to 1.5.6
> ----
> 
> Revision: 728331
> Author: bentmann
> Date: 19:48:54, samedi 20 décembre 2008
> Message:
> o Updated all plugins to use maven-invoker-plugin:1.3 to workaround MNG-3284
> and bogus CI failures
> ----
> 
> Revision: 728432
> Author: bentmann
> Date: 13:29:50, dimanche 21 décembre 2008
> Message:
> o Adjusted IT settings to compensate for the unusual unix-style local repo
> path used on the Windows nodes of the Hudson grid
> ----
> 
> 
> Revision: 728546
> Author: bentmann
> Date: 23:56:51, dimanche 21 décembre 2008
> Message:
> o Fixed svn:keywords
> ----
> 
> Revision: 731252
> Author: bentmann
> Date: 14:11:57, dimanche 4 janvier 2009
> Message:
> o Avoided deprecated syntax @parameter expression="${component...}"
> ----
> 
> Revision: 745196
> Author: brianf
> Date: 20:16:04, mardi 17 février 2009
> Message:
> use the latest parents
> ----
> 
> Revision: 746480
> Author: bentmann
> Date: 11:24:49, samedi 21 février 2009
> Message:
> o Inherited from maven-plugins:13
> ----
> 
> Revision: 751080
> Author: hboutemy
> Date: 22:36:09, vendredi 6 mars 2009
> Message:
> used http://maven.apache.org/xsd/* for schema location
> ----
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org