You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/15 20:25:40 UTC
[GitHub] [kafka] hachikuji opened a new pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer
hachikuji opened a new pull request #11502:
URL: https://github.com/apache/kafka/pull/11502
This patch marks the following arguments as deprecated in kafka-acls.sh as documented in [KIP-604](https://cwiki.apache.org/confluence/display/KAFKA/KIP-604%3A+Remove+ZooKeeper+Flags+from+the+Administrative+Tools): --authorizer, --authorizer-properties, and --zk-tls-config-file.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11502:
URL: https://github.com/apache/kafka/pull/11502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11502:
URL: https://github.com/apache/kafka/pull/11502#issuecomment-969291197
cc @dajac It would be nice to do this in 3.1 if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11502: KAFKA-13071; Deprecate support for changing acls through the authorizer
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #11502:
URL: https://github.com/apache/kafka/pull/11502#discussion_r750109834
##########
File path: core/src/main/scala/kafka/admin/AclCommand.scala
##########
@@ -499,13 +502,17 @@ object AclCommand extends Logging {
.describedAs("command-config")
.ofType(classOf[String])
- val authorizerOpt = parser.accepts("authorizer", "Fully qualified class name of the authorizer, defaults to kafka.security.authorizer.AclAuthorizer.")
+ val authorizerOpt = parser.accepts("authorizer", "DEPRECATED: Fully qualified class name of " +
+ "the authorizer, which defaults to kafka.security.authorizer.AclAuthorizer if --bootstrap-server is not provided. " +
+ AclCommand.AuthorizerDeprecationMessage)
.withRequiredArg
.describedAs("authorizer")
.ofType(classOf[String])
- val authorizerPropertiesOpt = parser.accepts("authorizer-properties", "REQUIRED: properties required to configure an instance of Authorizer. " +
- "These are key=val pairs. For the default authorizer the example values are: zookeeper.connect=localhost:2181")
+ val authorizerPropertiesOpt = parser.accepts("authorizer-properties", "DEPRECATED: The " +
+ "properties required to configure an instance of the Authorizer specified by --authorizer. " +
+ "These are key=val pairs. For the default authorizer, example values are: zookeeper.connect=localhost:2181." +
Review comment:
nit: Need to add a space after the `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org