You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Stefan Bodewig (JIRA)" <ji...@apache.org> on 2010/08/12 15:00:22 UTC
[jira] Created: (COCOON-2296) [PATCH] Make flowscript work with
Commons JXPath 1.3
[PATCH] Make flowscript work with Commons JXPath 1.3
----------------------------------------------------
Key: COCOON-2296
URL: https://issues.apache.org/jira/browse/COCOON-2296
Project: Cocoon
Issue Type: Improvement
Components: - Flowscript
Affects Versions: 2.2, 2.2-dev (Current SVN)
Reporter: Stefan Bodewig
Priority: Minor
Apache Commons JXPath released almost exactly two years ago added a method
protected String escape(String)
to the NodePointer class (see http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/NodePointer.java?r1=618011&r2=618087 ) this method's signature matches the one in org.apache.cocoon.components.flow.javascript.ScriptablePropertyPointer which extends NodePointer - except that ScriptablePropertyPointer's version is private and thus cannot override the one in NodePointer.
The method not only looks like yours, it also does the same thing (in a slightly different way).
Given that JXPath 1.3 boasts a lot of bugfixes, users may want to upgrade. The easiest fix would be to upgrade to 1.3 in Cocoon, remove the method in ScriptablePropertyPointer and use the base class version - this is what the attached patch does.
This issue has been found by Gump http://vmgump.apache.org/gump/public/cocoon/cocoon22-flowscript-impl/gump_work/build_cocoon_cocoon22-flowscript-impl.html after I ensured flowscript doesn't see the latest version of Rhino.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2296) [PATCH] Make flowscript work with
Commons JXPath 1.3
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Bodewig updated COCOON-2296:
-----------------------------------
Attachment: flowscript-jxpath-13.patch
Patch that upgrades the JXPath dependency to 1.3 and removes the escape method
> [PATCH] Make flowscript work with Commons JXPath 1.3
> ----------------------------------------------------
>
> Key: COCOON-2296
> URL: https://issues.apache.org/jira/browse/COCOON-2296
> Project: Cocoon
> Issue Type: Improvement
> Components: - Flowscript
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Stefan Bodewig
> Priority: Minor
> Attachments: flowscript-jxpath-13.patch
>
>
> Apache Commons JXPath - released almost exactly two years ago - added a method
> protected String escape(String)
> to the NodePointer class (see http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/NodePointer.java?r1=618011&r2=618087 ) this method's signature matches the one in org.apache.cocoon.components.flow.javascript.ScriptablePropertyPointer which extends NodePointer - except that ScriptablePropertyPointer's version is private and thus cannot override the one in NodePointer.
> The method not only looks like yours, it also does the same thing (in a slightly different way).
> Given that JXPath 1.3 boasts a lot of bugfixes, users may want to upgrade. The easiest fix would be to upgrade to 1.3 in Cocoon, remove the method in ScriptablePropertyPointer and use the base class version - this is what the attached patch does.
> This issue has been found by Gump http://vmgump.apache.org/gump/public/cocoon/cocoon22-flowscript-impl/gump_work/build_cocoon_cocoon22-flowscript-impl.html after I ensured flowscript doesn't see the latest version of Rhino.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2296) [PATCH] Make flowscript work with
Commons JXPath 1.3
Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Bodewig updated COCOON-2296:
-----------------------------------
Description:
Apache Commons JXPath - released almost exactly two years ago - added a method
protected String escape(String)
to the NodePointer class (see http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/NodePointer.java?r1=618011&r2=618087 ) this method's signature matches the one in org.apache.cocoon.components.flow.javascript.ScriptablePropertyPointer which extends NodePointer - except that ScriptablePropertyPointer's version is private and thus cannot override the one in NodePointer.
The method not only looks like yours, it also does the same thing (in a slightly different way).
Given that JXPath 1.3 boasts a lot of bugfixes, users may want to upgrade. The easiest fix would be to upgrade to 1.3 in Cocoon, remove the method in ScriptablePropertyPointer and use the base class version - this is what the attached patch does.
This issue has been found by Gump http://vmgump.apache.org/gump/public/cocoon/cocoon22-flowscript-impl/gump_work/build_cocoon_cocoon22-flowscript-impl.html after I ensured flowscript doesn't see the latest version of Rhino.
was:
Apache Commons JXPath released almost exactly two years ago added a method
protected String escape(String)
to the NodePointer class (see http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/NodePointer.java?r1=618011&r2=618087 ) this method's signature matches the one in org.apache.cocoon.components.flow.javascript.ScriptablePropertyPointer which extends NodePointer - except that ScriptablePropertyPointer's version is private and thus cannot override the one in NodePointer.
The method not only looks like yours, it also does the same thing (in a slightly different way).
Given that JXPath 1.3 boasts a lot of bugfixes, users may want to upgrade. The easiest fix would be to upgrade to 1.3 in Cocoon, remove the method in ScriptablePropertyPointer and use the base class version - this is what the attached patch does.
This issue has been found by Gump http://vmgump.apache.org/gump/public/cocoon/cocoon22-flowscript-impl/gump_work/build_cocoon_cocoon22-flowscript-impl.html after I ensured flowscript doesn't see the latest version of Rhino.
Affects version (Component): (was: Parent values: Blocks: Flowscript(10165). Level 1 values: 1.0.0(10390). )
> [PATCH] Make flowscript work with Commons JXPath 1.3
> ----------------------------------------------------
>
> Key: COCOON-2296
> URL: https://issues.apache.org/jira/browse/COCOON-2296
> Project: Cocoon
> Issue Type: Improvement
> Components: - Flowscript
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Stefan Bodewig
> Priority: Minor
>
> Apache Commons JXPath - released almost exactly two years ago - added a method
> protected String escape(String)
> to the NodePointer class (see http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/NodePointer.java?r1=618011&r2=618087 ) this method's signature matches the one in org.apache.cocoon.components.flow.javascript.ScriptablePropertyPointer which extends NodePointer - except that ScriptablePropertyPointer's version is private and thus cannot override the one in NodePointer.
> The method not only looks like yours, it also does the same thing (in a slightly different way).
> Given that JXPath 1.3 boasts a lot of bugfixes, users may want to upgrade. The easiest fix would be to upgrade to 1.3 in Cocoon, remove the method in ScriptablePropertyPointer and use the base class version - this is what the attached patch does.
> This issue has been found by Gump http://vmgump.apache.org/gump/public/cocoon/cocoon22-flowscript-impl/gump_work/build_cocoon_cocoon22-flowscript-impl.html after I ensured flowscript doesn't see the latest version of Rhino.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.