[GitHub] [lucene-solr] eribeiro commented on a change in pull request #1083: SOLR-13662: Fixes to package manager

[GitBox <gi...@apache.org>]

eribeiro commented on a change in pull request #1083: SOLR-13662: Fixes to package manager
URL: https://github.com/apache/lucene-solr/pull/1083#discussion_r357945125
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java
 ##########
 @@ -220,12 +239,21 @@ private boolean deployPackage(SolrPackageInstance packageInstance, boolean pegTo
       }
     }
 
-    // Verify that package was successfully deployed
-    boolean success = verify(packageInstance, collections);
-    if (success) {
-      PackageUtils.printGreen("Deployed and verified package: " + packageInstance.name + ", version: " + packageInstance.version);
+    List<String> deployedCollections = new ArrayList<String>();
+    for (String c: collections) if (alreadyDeployed.contains(c) == false) deployedCollections.add(c);
+
+    boolean success = true;
+    if (deployedCollections.isEmpty() == false) {
+      // Verify that package was successfully deployed
+      success = verify(packageInstance, deployedCollections);
+      if (success) {
+        PackageUtils.printGreen("Deployed on " + deployedCollections + " and verified package: " + packageInstance.name + ", version: " + packageInstance.version);
+      }
     }
-    return success;
+    if (alreadyDeployed.isEmpty() == false) {
+      PackageUtils.printRed("Already Deployed on " + alreadyDeployed + ", package: " + packageInstance.name + ", version: " + packageInstance.version);
+    }
+    return alreadyDeployed.isEmpty()==false? false: success;
 
 Review comment:
   ```suggestion
       return alreadyDeployed.isEmpty() && success;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org