You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/22 16:20:52 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1279: Implement lstat and realpath

xiaoxiang781216 opened a new pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279


   ## Summary
   And fix _Exit false alarm.
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-648633893


   symlink as link sounds wrong to me.
   an implementation which already returns EPERM would be more correct.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-648639475


   > symlink as link sounds wrong to me.
   > an implementation which always returns EPERM would be more correct.
   
   From my understanding, the current implement of link is actually symlink:
   https://github.com/apache/incubator-nuttx/blob/master/fs/vfs/fs_link.c#L75
   link doesn't really implement in NuttX at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-650025194


   @xiaoxiang781216 ok, thank you for explanation. i didn't know what nuttx's link() is.
   
   btw, what's your motivation to add symlink? just curious.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-650048863


   @xiaoxiang781216 thank you for info


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-650042691


   I am upgrading libcxx to the latest version which need symlink to implement C++ 17 filesystem library.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-650673200


   @yamt if you don't any concern, please help me merge the patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt edited a comment on pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
yamt edited a comment on pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279#issuecomment-648633893


   symlink as link sounds wrong to me.
   an implementation which always returns EPERM would be more correct.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1279: Implement lstat and realpath

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1279:
URL: https://github.com/apache/incubator-nuttx/pull/1279


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org