You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/06/29 23:03:58 UTC
Review Request 36022: Remove http specific protocol from master
browse in webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36022/
-----------------------------------------------------------
Review request for mesos, Adam B and Benjamin Hindman.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/webui/master/static/browse.html ce55d6b56b37f8884b82d92a1e10fd9a59140f47
Diff: https://reviews.apache.org/r/36022/diff/
Testing
-------
hit browse endpoint download button and verified in chrome tools that the url did not have `http:`.
Thanks,
Joris Van Remoortere
Re: Review Request 36022: Remove http specific protocol from master
browse in webui.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36022/#review89813
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 29406, 31207, 36003, 36018, 36022]
All tests passed.
- Mesos ReviewBot
On June 29, 2015, 9:03 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36022/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 9:03 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html ce55d6b56b37f8884b82d92a1e10fd9a59140f47
>
> Diff: https://reviews.apache.org/r/36022/diff/
>
>
> Testing
> -------
>
> hit browse endpoint download button and verified in chrome tools that the url did not have `http:`.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36022: Remove http specific protocol from master
browse in webui.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36022/#review89797
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On June 29, 2015, 2:03 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36022/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 2:03 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html ce55d6b56b37f8884b82d92a1e10fd9a59140f47
>
> Diff: https://reviews.apache.org/r/36022/diff/
>
>
> Testing
> -------
>
> hit browse endpoint download button and verified in chrome tools that the url did not have `http:`.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>