You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/06 20:12:14 UTC
[GitHub] [geode] pivotal-jbarrett opened a new pull request #7243: GEODE-9930: Mark ClusterManagementOperation @Experimental
pivotal-jbarrett opened a new pull request #7243:
URL: https://github.com/apache/geode/pull/7243
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #7243: GEODE-9930: Mark ClusterManagementOperation @Experimental
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #7243:
URL: https://github.com/apache/geode/pull/7243#discussion_r779849785
##########
File path: buildSrc/src/main/resources/japicmp_exceptions.json
##########
@@ -1,3 +1,6 @@
{
"Class org.apache.geode.management.builder.GeodeClusterManagementServiceBuilder": "Moved internal class to fix split packages between geode-core and geode-management",
+ "Class org.apache.geode.management.api.ClusterManagementOperation": "Fixed missing @Experimental annotation",
+ "Method org.apache.geode.management.api.ClusterManagementOperation.getEndpoint()": "Fixed missing @Experimental annotation",
Review comment:
aren't the methods implicitly experimental, and therefore ignored now, by the class being marked Experimental? So these last 2 lines might be unnecessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #7243: GEODE-9930: Mark ClusterManagementOperation @Experimental
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #7243:
URL: https://github.com/apache/geode/pull/7243#discussion_r779849785
##########
File path: buildSrc/src/main/resources/japicmp_exceptions.json
##########
@@ -1,3 +1,6 @@
{
"Class org.apache.geode.management.builder.GeodeClusterManagementServiceBuilder": "Moved internal class to fix split packages between geode-core and geode-management",
+ "Class org.apache.geode.management.api.ClusterManagementOperation": "Fixed missing @Experimental annotation",
+ "Method org.apache.geode.management.api.ClusterManagementOperation.getEndpoint()": "Fixed missing @Experimental annotation",
Review comment:
aren't the methods implicitly experimental, and therefore ignored now, by the class being marked Experimental? So these last 2 lines might be unnecessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett merged pull request #7243: GEODE-9930: Mark ClusterManagementOperation @Experimental
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett merged pull request #7243:
URL: https://github.com/apache/geode/pull/7243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett merged pull request #7243: GEODE-9930: Mark ClusterManagementOperation @Experimental
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett merged pull request #7243:
URL: https://github.com/apache/geode/pull/7243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org