[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #199: [FLINK-27551] Update status manually instead of relying on updatecontrol

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #199:
URL: https://github.com/apache/flink-kubernetes-operator/pull/199#discussion_r869109094


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java:
##########
@@ -86,26 +92,29 @@ public FlinkDeploymentController(
     @Override
     public DeleteControl cleanup(FlinkDeployment flinkApp, Context context) {
         LOG.info("Deleting FlinkDeployment");
+        OperatorUtils.updateStatusFromCache(flinkApp, statusCache);

Review Comment:
   I think the user cannot update the status either. But in a way yes this means that only the Flink Operator can update the status that is correct.
   
   Later when this is improved in the java operator sdk (version 3 ) we could rework this if we think it's important but this should not be a serious limiation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org