You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Josh Canfield <jo...@gmail.com> on 2012/09/04 17:54:12 UTC
Re: Submmiting bug fixes and their propagation to releases
Hi Boris.
You can get the latest tapestry code from the git repository. It's
documented here:
http://tapestry.apache.org/download.html
git clone https://git-wip-us.apache.org/repos/asf/tapestry-5.git
You can find lots of docs for using git online, including how to create a
patch.
Have fun!
Josh
On Thu, Aug 30, 2012 at 4:11 AM, bhorvat <ho...@gmail.com> wrote:
> Hi all,
>
> I have had a bug a few months back that I figure out how to fix by
> overriding one of the tapestry js files and then using that one. The
> problem
> description and fix can be found on the created jira
>
> https://issues.apache.org/jira/browse/TAP5-1903
> https://issues.apache.org/jira/browse/TAP5-1903
>
> Can someone please help me to create a bug fix (or can someone do this for
> me) and then to see if it can be submitted into next release.
>
> I am using NetBeans and Mercurial as my work environement so I am not sure
> if I can create bug fix using that or do I need to install and use
> something
> else?
>
>
>
>
> --
> View this message in context:
> http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
Re: Submmiting bug fixes and their propagation to releases
Posted by bhorvat <ho...@gmail.com>.
Tnx for the tip. I solve this by doing stuff using the git command line :)
but for bigger changes will defiantly I will have to look into this.
cheers
--
View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716408.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Submmiting bug fixes and their propagation to releases
Posted by Alex Kotchnev <ak...@gmail.com>.
The netbeans gradle plugin (
https://github.com/kelemen/netbeans-gradle-project ) seems to work OK for
opening up the tapestry projects for me.
Cheers,
Alex K
On Sun, Sep 16, 2012 at 6:21 PM, bhorvat <ho...@gmail.com> wrote:
> For some reason I can not import the project into Netbeans. Has anyone
> tried
> that before, also do I need to install something about the gradle?
>
> Also if someone can help me and create a patch for this I would really be
> grateful. The bug fix is very ease, basically just one if check for the in
> the javascript
> http://tapestry.1045711.n5.nabble.com/file/n5716334/upload.js upload.js
>
> cheers
>
>
>
> --
> View this message in context:
> http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716334.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
Re: Submmiting bug fixes and their propagation to releases
Posted by Bob Harner <bo...@gmail.com>.
Definitely
On Mon, Sep 17, 2012 at 12:50 PM, bhorvat <ho...@gmail.com> wrote:
> Hi bobharner tnx for help.
>
> So is this something that I can look forward in the next release?
>
>
>
> --
> View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716359.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Submmiting bug fixes and their propagation to releases
Posted by bhorvat <ho...@gmail.com>.
Hi bobharner tnx for help.
So is this something that I can look forward in the next release?
--
View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716359.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Submmiting bug fixes and their propagation to releases
Posted by Bob Harner <bo...@gmail.com>.
He did attach the patch to the JIRA, and I just applied the patch and
committed it to the master (but not the 5.3 branch yet).
On Sun, Sep 16, 2012 at 9:33 PM, Lenny Primak <lp...@hope.nyc.ny.us> wrote:
> Do you have a JIRA opened associated with this patch, is this patch attached to this JIRA?
> If not, it's a non-starter. If you did, please attach your JIRA to your e-mail, so its easy for a committer to apply
> your patch.
>
> On Sep 16, 2012, at 7:04 PM, bhorvat <ho...@gmail.com> wrote:
>
>> http://tapestry.1045711.n5.nabble.com/file/n5716335/javascript_upload_rerender.patch
>> javascript_upload_rerender.patch
>>
>> I think that I have managed to create a patch. Can someone try to apply it
>> to see if it works?
>>
>> Also what is the procedure to push this into the branch?
>>
>> I have been using the fixed for the last few months and also it is a fairly
>> trivial fix
>>
>> tnx and cheers all
>>
>>
>>
>> --
>> View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716335.html
>> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Submmiting bug fixes and their propagation to releases
Posted by Lenny Primak <lp...@hope.nyc.ny.us>.
Do you have a JIRA opened associated with this patch, is this patch attached to this JIRA?
If not, it's a non-starter. If you did, please attach your JIRA to your e-mail, so its easy for a committer to apply
your patch.
On Sep 16, 2012, at 7:04 PM, bhorvat <ho...@gmail.com> wrote:
> http://tapestry.1045711.n5.nabble.com/file/n5716335/javascript_upload_rerender.patch
> javascript_upload_rerender.patch
>
> I think that I have managed to create a patch. Can someone try to apply it
> to see if it works?
>
> Also what is the procedure to push this into the branch?
>
> I have been using the fixed for the last few months and also it is a fairly
> trivial fix
>
> tnx and cheers all
>
>
>
> --
> View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716335.html
> Sent from the Tapestry - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Submmiting bug fixes and their propagation to releases
Posted by bhorvat <ho...@gmail.com>.
http://tapestry.1045711.n5.nabble.com/file/n5716335/javascript_upload_rerender.patch
javascript_upload_rerender.patch
I think that I have managed to create a patch. Can someone try to apply it
to see if it works?
Also what is the procedure to push this into the branch?
I have been using the fixed for the last few months and also it is a fairly
trivial fix
tnx and cheers all
--
View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716335.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Submmiting bug fixes and their propagation to releases
Posted by bhorvat <ho...@gmail.com>.
For some reason I can not import the project into Netbeans. Has anyone tried
that before, also do I need to install something about the gradle?
Also if someone can help me and create a patch for this I would really be
grateful. The bug fix is very ease, basically just one if check for the in
the javascript
http://tapestry.1045711.n5.nabble.com/file/n5716334/upload.js upload.js
cheers
--
View this message in context: http://tapestry.1045711.n5.nabble.com/Submmiting-bug-fixes-and-their-propagation-to-releases-tp5715905p5716334.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org