[PR] Use the resolver's own HTTP transport in the report plugin tests [maven-surefire]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz opened a new pull request, #3414:
URL: https://github.com/apache/maven-surefire/pull/3414

   `maven-surefire-report-plugin`'s test classpath carried two artifacts to give Resolver a way of speaking HTTP:
   
   ```xml
   <artifactId>maven-resolver-transport-wagon</artifactId>
   <artifactId>wagon-http-lightweight</artifactId>
   ```
   
   Resolver has had its own HTTP transport since 1.0, so `maven-resolver-transport-http` at the same `${resolverVersion}` (1.9.27 here) does the same job on its own. `maven-resolver-connector-basic` is untouched — that is the connector, not the transport.
   
   `wagon-http-lightweight` is additionally marked for removal in Wagon 4.0.0, and nothing in these tests needs a Wagon provider in particular; it was only ever the thing on the other side of the wagon transport.
   
   **Verified:** `mvn -pl maven-surefire-report-plugin test` gives 13 tests, 0 failures, both before and after.
   
   This came out of a survey of how Maven projects actually depend on Wagon. The identical pattern is being changed in apache/maven-project-info-reports-plugin#648 and apache/maven-checkstyle-plugin#681. It deliberately is **not** being changed in maven-doap-plugin: its tests resolve through the legacy `maven-compat` `WagonManager`, which looks up a Wagon by protocol, so a resolver transport cannot stand in — swapping it there fails with `Cannot find wagon which supports the requested protocol: https`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use the resolver's own HTTP transport in the report plugin tests [maven-surefire]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz merged PR #3414:
URL: https://github.com/apache/maven-surefire/pull/3414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org