[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #491: [operator] better build system support

[GitBox <gi...@apache.org>]

advancedxy commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1071717380


##########
deploy/kubernetes/operator/Makefile:
##########
@@ -16,12 +16,16 @@
 #
 
 # REGISTRY URL to use all building/pushing image targets
-REGISTRY ?= UNKNOWN_REGISTRY
+REGISTRY ?= ''
+
+ifneq ('', ${REGISTRY})
+REGISTRY := $(addsuffix /, ${REGISTRY})
+endif
 
 MODULES ?= webhook controller
 
 # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
-ENVTEST_K8S_VERSION = 1.22.1
+ENVTEST_K8S_VERSION = 1.24.1

Review Comment:
   which lib should I update the version?  `k8s.io/api v0.22.2` -> what version?
   
   I'm not quite family with envtest...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org