[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

[GitBox <gi...@apache.org>]

adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1039819121


##########
libminifi/include/utils/Enum.h:
##########
@@ -39,6 +39,7 @@ namespace utils {
     constexpr Clazz(Type value = static_cast<Type>(-1)) : value_{value} {} \
     explicit Clazz(const std::string& str) : value_{parse(str.c_str()).value_} {} \
     explicit Clazz(const char* str) : value_{parse(str).value_} {} \
+    explicit Clazz(std::nullptr_t) = delete; \

Review Comment:
   Previously initializing with `0` was allowed, with the `const char*` constructor. This could be misleading, not it's not allowed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org