[GitHub] [couchdb] iilyak commented on a diff in pull request #4581: OTP 26 compatibility

["iilyak (via GitHub)" <gi...@apache.org>]

iilyak commented on code in PR #4581:
URL: https://github.com/apache/couchdb/pull/4581#discussion_r1202802115


##########
src/couch_log/src/couch_log_formatter.erl:
##########
@@ -467,12 +467,14 @@ format_meta(Meta) ->
     %% https://www.rfc-editor.org/rfc/rfc5424.html#section-6.3
     %% iut="3" eventSource="Application" eventID="1011"
     string:join(
-        maps:fold(
-            fun(K, V, Acc) ->
-                [to_str(K, V) | Acc]
-            end,
-            [],
-            Meta
+        lists:sort(

Review Comment:
   I had a concern that sorting the map elements would harm the performance. However given the fact that reports would be small we can have a compromise. Which is every time we introduce a new report type we would try to select shorter names for keys. 
   
   I am not going to block this PR on the map order grounds. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org