You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 17:21:27 UTC
[GitHub] [arrow-rs] psvri opened a new pull request, #2488: refactoring union builder apis
psvri opened a new pull request, #2488:
URL: https://github.com/apache/arrow-rs/pull/2488
# Which issue does this PR close?
Partially implements #2054
# Rationale for this change
Refactor apis to make a consistent new and with_capacity functions
# What changes are included in this PR?
introduced funcions with_capacity_sparse and with_capacity_dense and removed capacity option from new functions
# Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2488: refactoring union builder apis
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2488:
URL: https://github.com/apache/arrow-rs/pull/2488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2488: refactoring union builder apis
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2488:
URL: https://github.com/apache/arrow-rs/pull/2488#issuecomment-1220454885
Could you merge master so that the CI runs clean :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2488: refactoring union builder apis
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2488:
URL: https://github.com/apache/arrow-rs/pull/2488#discussion_r950105330
##########
arrow/src/array/builder/union_builder.rs:
##########
@@ -168,8 +178,8 @@ impl UnionBuilder {
}
}
- /// Creates a new sparse array builder.
- pub fn new_sparse(capacity: usize) -> Self {
Review Comment:
Not something for this PR but we should probably save the capacity and use it when we create new builder children
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2488: Refactor UnionBuilder Constructors
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2488:
URL: https://github.com/apache/arrow-rs/pull/2488#issuecomment-1220584118
Benchmark runs are scheduled for baseline = 930d2d7e926b103a68832b7b23016eb1be36e10e and contender = ac8b0eb783e5b5ba6aed5cb33d05b1cdae113dd7. ac8b0eb783e5b5ba6aed5cb33d05b1cdae113dd7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5f17e5edf957484b894fff35d019ba24...b4bf14a2758344faae1ac82f7d632fad/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/09b833a6359c495cb21c230c959d18d9...c12b93ac5bd3446498005055f320b9a8/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/36125b5726af40e693f68e69f788cf7f...8cb6c675b48e4956a1c5cf35711db857/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a632a2de6e5f4d8bbdaa4b89f9da1882...96240c9786f741ae866e85ebebdb57b6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2488: refactoring union builder apis
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2488:
URL: https://github.com/apache/arrow-rs/pull/2488#discussion_r950105330
##########
arrow/src/array/builder/union_builder.rs:
##########
@@ -168,8 +178,8 @@ impl UnionBuilder {
}
}
- /// Creates a new sparse array builder.
- pub fn new_sparse(capacity: usize) -> Self {
Review Comment:
Not something for this PR but we should probably save the capacity and use it when we create new builder children
Ticket created - https://github.com/apache/arrow-rs/issues/2523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org