You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/29 18:16:59 UTC
[GitHub] [incubator-inlong-website] Chever-John opened a new pull request, #387: feat(Website): Add official website content search button
Chever-John opened a new pull request, #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387
Fixes #<xyz>
where *XYZ* should be replaced by the actual issue number.
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/inlong-website/pull/387#issuecomment-1248950575
@bluewang Give me a few days, I'll give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] dockerzhang commented on a diff in pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#discussion_r884405289
##########
docusaurus.config.js:
##########
@@ -238,6 +238,12 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula');
theme: require('prism-react-renderer/themes/dracula'),
darkTheme: darkCodeTheme,
},
+ algolia: {
+ appId: 'YUW9QEL53E',
Review Comment:
Do we have an expiry date for the appId and key? if it works for a long time, I think the private email is not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140945825
@dockerzhang By the way, when I've solved problems in some communities, they don't recommend using rebase and force push code when the code has already been committed. So I have this question~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] leezng commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
leezng commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140638961
@Chever-John
Did you use your private email to register the appId and key on algolia?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on a diff in pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#discussion_r884391776
##########
docusaurus.config.js:
##########
@@ -238,6 +238,12 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula');
theme: require('prism-react-renderer/themes/dracula'),
darkTheme: darkCodeTheme,
},
+ algolia: {
+ appId: 'YUW9QEL53E',
Review Comment:
This is true as far as the facts are concerned. But I think I got access to @dockerzhang before I operated. I cc the email to him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1141585194
@dockerzhang My pleasure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] dockerzhang commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140639402
@Chever-John the CI build failed, please rebase the master for https://github.com/apache/incubator-inlong-website/pull/388 merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] bluewang commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
bluewang commented on PR #387:
URL: https://github.com/apache/inlong-website/pull/387#issuecomment-1248966203
> @bluewang Give me a few days, I'll give it a try.
@Chever-John OK. Waiting for your good news
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] dockerzhang commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1141585000
@Chever-John LGTM, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] dockerzhang merged pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on a diff in pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#discussion_r884695973
##########
docusaurus.config.js:
##########
@@ -238,6 +238,12 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula');
theme: require('prism-react-renderer/themes/dracula'),
darkTheme: darkCodeTheme,
},
+ algolia: {
+ appId: 'YUW9QEL53E',
Review Comment:
Hi, I am back for the newest status. @leezng @dockerzhang
1. I have consulted with the relevant developers at Apache APISIX and Apache Skywalking. Based on their experience, they believe that it is perfectly fine to register using a private account, and then if you need to replace it in the future, email the official.
2. I didn't get a valid answer about the key's expiration date, and I'm waiting for an update. It seems that everyone doesn't care about it.
3. I am waiting for the official's reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on a diff in pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#discussion_r884695973
##########
docusaurus.config.js:
##########
@@ -238,6 +238,12 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula');
theme: require('prism-react-renderer/themes/dracula'),
darkTheme: darkCodeTheme,
},
+ algolia: {
+ appId: 'YUW9QEL53E',
Review Comment:
Hi, I am back for the newest status.
1. I have consulted with the relevant developers at Apache APISIX and Apache Skywalking. Based on their experience, they believe that it is perfectly fine to register using a private account, and then if you need to replace it in the future, email the official.
2. I didn't get a valid answer about the key's expiration date, and I'm waiting for an update. It seems that everyone doesn't care about it.
3. I am waiting for the official's reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] bluewang commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
bluewang commented on PR #387:
URL: https://github.com/apache/inlong-website/pull/387#issuecomment-1248886800
> @dockerzhang @bluewang @leezng I found the search engine seems do not to work. Let me check it.
Is there any progress on this situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] dockerzhang commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140672924
> @dockerzhang Yes, I have successfully completed the rebase, but using the force push method. Should I be careful not to use force push for community commits?
it's a usual operation for `force push` after rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140640027
@dockerzhang Sure, sir~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] leezng commented on a diff in pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#discussion_r884388623
##########
docusaurus.config.js:
##########
@@ -238,6 +238,12 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula');
theme: require('prism-react-renderer/themes/dracula'),
darkTheme: darkCodeTheme,
},
+ algolia: {
+ appId: 'YUW9QEL53E',
Review Comment:
@Chever-John
Did you use your private email to register the appId and key on algolia?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1141594327
@dockerzhang @bluewang @leezng I found the search engine seems do not to work. Let me check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140676001
@dockerzhang This is a potential problem to consider. Let me check it and give you a reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on a diff in pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#discussion_r884391776
##########
docusaurus.config.js:
##########
@@ -238,6 +238,12 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula');
theme: require('prism-react-renderer/themes/dracula'),
darkTheme: darkCodeTheme,
},
+ algolia: {
+ appId: 'YUW9QEL53E',
Review Comment:
This is true as far as the facts are concerned. But I think I got access to Alex before I operated. I forwarded the email to Alex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong-website] Chever-John commented on pull request #387: [INLONG-1831][Website] Add official website content search button
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #387:
URL: https://github.com/apache/incubator-inlong-website/pull/387#issuecomment-1140645902
@dockerzhang Yes, I have successfully completed the rebase, but using the force push method. Should I be careful not to use force push for community commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org