You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/02/14 17:01:19 UTC
Review Request 65656: Removed unnecessary compiler flag in build
instructions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
After the recent upgrade to the bundled boost version, it
is not necessary anymore to add `-Wno-deprecated-declaration`
to the compiler flags.
Since users of Mesos shouldn't be expected to fix warnings in
our code, a reference to the `--disable-werror` configure flag
was also provided to allow easily ignoring compiler warnings.
Diffs
-----
docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15
Diff: https://reviews.apache.org/r/65656/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 65656: Removed unnecessary compiler flag in build
instructions.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/#review197615
-----------------------------------------------------------
Fix it, then Ship it!
docs/building.md
Line 103 (original), 103 (patched)
<https://reviews.apache.org/r/65656/#comment277831>
While I think the ghist is entirely right - it is not accurate.
What about 's/to ignore them/to not escalate them to errors/'?
- Till Toenshoff
On Feb. 14, 2018, 5:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65656/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 5:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the recent upgrade to the bundled boost version, it
> is not necessary anymore to add `-Wno-deprecated-declaration`
> to the compiler flags.
>
> Since users of Mesos shouldn't be expected to fix warnings in
> our code, a reference to the `--disable-werror` configure flag
> was also provided to allow easily ignoring compiler warnings.
>
>
> Diffs
> -----
>
> docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15
>
>
> Diff: https://reviews.apache.org/r/65656/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65656: Removed unnecessary compiler flag in build
instructions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/#review197568
-----------------------------------------------------------
PASS: Mesos patch 65656 was successfully built and tested.
Reviews applied: `['65656']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65656
- Mesos Reviewbot Windows
On Feb. 14, 2018, 9:01 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65656/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 9:01 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the recent upgrade to the bundled boost version, it
> is not necessary anymore to add `-Wno-deprecated-declaration`
> to the compiler flags.
>
> Since users of Mesos shouldn't be expected to fix warnings in
> our code, a reference to the `--disable-werror` configure flag
> was also provided to allow easily ignoring compiler warnings.
>
>
> Diffs
> -----
>
> docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15
>
>
> Diff: https://reviews.apache.org/r/65656/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65656: Removed unnecessary compiler flag in build
instructions.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/#review197583
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65656]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 14, 2018, 9:01 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65656/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 9:01 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the recent upgrade to the bundled boost version, it
> is not necessary anymore to add `-Wno-deprecated-declaration`
> to the compiler flags.
>
> Since users of Mesos shouldn't be expected to fix warnings in
> our code, a reference to the `--disable-werror` configure flag
> was also provided to allow easily ignoring compiler warnings.
>
>
> Diffs
> -----
>
> docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15
>
>
> Diff: https://reviews.apache.org/r/65656/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65656: Removed unnecessary compiler flag in build
instructions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/#review197620
-----------------------------------------------------------
PASS: Mesos patch 65656 was successfully built and tested.
Reviews applied: `['65656']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65656
- Mesos Reviewbot Windows
On Feb. 15, 2018, 1:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65656/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2018, 1:40 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the recent upgrade to the bundled boost version, it
> is not necessary anymore to add `-Wno-deprecated-declaration`
> to the compiler flags.
>
> Since users of Mesos shouldn't be expected to fix warnings in
> our code, a reference to the `--disable-werror` configure flag
> was also provided to allow easily ignoring compiler warnings.
>
>
> Diffs
> -----
>
> docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15
>
>
> Diff: https://reviews.apache.org/r/65656/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65656: Removed unnecessary compiler flag in build
instructions.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65656/
-----------------------------------------------------------
(Updated Feb. 15, 2018, 1:40 p.m.)
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
After the recent upgrade to the bundled boost version, it
is not necessary anymore to add `-Wno-deprecated-declaration`
to the compiler flags.
Since users of Mesos shouldn't be expected to fix warnings in
our code, a reference to the `--disable-werror` configure flag
was also provided to allow easily ignoring compiler warnings.
Diffs (updated)
-----
docs/building.md aa99fdbe62013453c005fea29e570bd12b356d15
Diff: https://reviews.apache.org/r/65656/diff/2/
Changes: https://reviews.apache.org/r/65656/diff/1-2/
Testing
-------
Thanks,
Benno Evers