[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #634: [#632]fix: respect volumes in rss spec

["wangao1236 (via GitHub)" <gi...@apache.org>]

wangao1236 commented on code in PR #634:
URL: https://github.com/apache/incubator-uniffle/pull/634#discussion_r1112571294


##########
deploy/kubernetes/operator/pkg/controller/sync/shuffleserver/shuffleserver_test.go:
##########
@@ -315,6 +334,18 @@ func TestGenerateSts(t *testing.T) {
 				return
 			},
 		},
+		{
+			name: "test custom volumes",
+			rss:  withCustomVolumes(testVolumes),
+			IsValidSts: func(sts *appsv1.StatefulSet, rss *uniffleapi.RemoteShuffleService) (valid bool, err error) {
+				for _, volume := range sts.Spec.Template.Spec.Volumes {
+					if volume.Name == testVolumeName {
+						return true, nil

Review Comment:
   Maybe we can compare the contents of your custom volume by deepcopy method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org