You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/09 09:08:34 UTC
[PR] fix(history): recover pagination when result totals shrink [rocketmq-dashboard]
Loyal-Young opened a new pull request, #5790:
URL: https://github.com/apache/rocketmq-dashboard/pull/5790
## What is the purpose of the change
Fixes #5783. Recover query-history pagination when a new instance or a reopened drawer has fewer records than the selected page. Both message and trace history use the same fixed page size.
## Brief changelog
- Clamp an out-of-range page using the returned total and reload the valid page.
- Hide the page-size selector because requests are fixed at 20 records.
- Cover both history tabs and the fixed-size pagination UI.
## Verifying this change
- Reproduced the invalid page request for both tabs and the unsupported page-size selector before the fix.
- All 9 MessageQueryHistoryDrawer tests passed after the fix.
- TypeScript app check, changed-file ESLint, and git diff --check passed.
- Full app build and backend tests were not rerun.
## Related work
Checked #5156: its deletion-specific page adjustment does not handle a successful response with a reduced total after changing instance. This change does not add delete or clear operations.
## AI assistance
AI assisted with tracing pagination state, drafting the bounded fix and component regressions, and checking test output. Tests exercise the rendered drawer and outgoing query parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(history): recover pagination when result totals shrink [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #5790:
URL: https://github.com/apache/rocketmq-dashboard/pull/5790#issuecomment-6261571066
Progress update (2026-10-19): GitHub currently reports the branch as mergeable. All five current CI checks pass. The change is ready for maintainer review. I will follow up on any new feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(history): recover pagination when result totals shrink [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5790:
URL: https://github.com/apache/rocketmq-dashboard/pull/5790#issuecomment-6264567313
Folded into #6703, merged into `rocketmq-studio` as 86aa49c34 — your change is in that commit and stays authored by you.
We batched six related message-history / import / LiteTopic / settings PRs (#6703 #5790 #6705 #6721 #6711 #5798) into a single integration commit to keep the history readable, so this one is closed as folded rather than merged separately. No action needed; the linked issue is closed as resolved by #6703.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(history): recover pagination when result totals shrink [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #5790: fix(history): recover pagination when result totals shrink
URL: https://github.com/apache/rocketmq-dashboard/pull/5790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org