Re: [PR] Minor: Fix name in ArrayFunctionRewriter, error not panic if `Expr::GetStructField` is planned [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #10564:
URL: https://github.com/apache/datafusion/pull/10564#discussion_r1605486971


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -234,7 +234,7 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> {
                     stride: _,
                 } => {
                     unreachable!(
-                        "ListRange should have been rewritten in OperatorToFunction"
+                        "ListRange should have been rewritten in ArrayFunctionRewriter"

Review Comment:
   Indeed -- it panics here: https://github.com/apache/datafusion/issues/10565
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org