You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/03 17:49:31 UTC
[GitHub] betodealmeida commented on issue #5545: [bugfix] don't cache empty
dataframe
betodealmeida commented on issue #5545: [bugfix] don't cache empty dataframe
URL: https://github.com/apache/incubator-superset/pull/5545#issuecomment-410328153
I can see both ways... if the query actually returned no data and we expect that the same query will keep returning no data in the future, then caching it is the right thing to do. OTOH, if the query returned no data because of a transient problem (no data currently available, eg) then it should not be cached.
In theory I think caching is the right thing to do, but in practice I've seen very few correct queries that return no data so we should not cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org