[GitHub] acoburn opened a new pull request #796: ISSUE 230: Enable Checkstyle on the conf package

[GitBox <gi...@apache.org>]

acoburn opened a new pull request #796: ISSUE 230: Enable Checkstyle on the conf package
URL: https://github.com/apache/bookkeeper/pull/796
 
 
   This is part of #230 and adds Checkstyle verification to the conf
   package in bookkeeper-server.
   
   As with #792, most of the changes here should be non-controversial. However, as with #792, there is a constant field whose name needed to be renamed. `AbstractConfiguration` has a `protected static final` field called `defaultLoader`. This field is used in the two implementing classes, so keeping `protected` visibility seems right. So in this case, the field has been renamed to `DEFAULT_LOADER` while keeping the `protected static final` modifiers.
   
   The changed line is: https://github.com/apache/bookkeeper/compare/master...acoburn:checkstyle_conf?expand=1#diff-b4f821552b13a688d62015e96092e08eR45

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services