You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by shanthoosh <gi...@git.apache.org> on 2018/05/26 23:50:13 UTC

[GitHub] samza pull request #537: SAMZA-1732: Reduce the coordination timeouts in Tes...

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/537

    SAMZA-1732: Reduce the coordination timeouts in TestZkLocalApplicationRunner tests.

    Currently all the tests in TestZkLocalApplicationRunner takes around 5 minutes to finish. Reducing the coordination timeout to reduce the test time.
     
    Changes in TestZkLocalApplicationRunner test timeout values:
    * Change debounce timeout from 20 seconds to 2 seconds.
    * Change task.shutdown timeout from 30 seconds to 5 seconds.
    * Change barrier timeout from 40 seconds to 2 seconds.
    
    **Verification:**
    
    ```bash
    [svenkata@svenkata-ld2 ~]$ cat ~/runTests-1.sh 
    i=0
    while [ $i -lt 151 ]; do
                    i=`expr $i + 1`
                    echo "Run " +$i 
                    ./gradlew clean :samza-test:test -Dtest.single="TestZkLocalApplicationRunner" --debug --stacktrace >> ~/test-logs-runTests-1_23
    
    done;
    ```
    
    **Result:**
     
    ```bash
    [svenkata@svenkata-ld2 ~]$ grep 'BUILD FAIL' test-logs-runTests-1_23 |wc -l
    0
    [svenkata@svenkata-ld2 ~]$ grep 'BUILD SUCCESS' test-logs-runTests-1_23 |wc -l
    151
    ```
    
    After this change, execution time of TestZkLocalApplicationRunner tests has reduced from `310` seconds to `55` seconds.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza reduce_zk_localAppRunnerTestTime

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #537
    
----
commit db1db2a00fa72b7afd8c80e74ccd116411197764
Author: Shanthoosh Venkataraman <sv...@...>
Date:   2018-05-26T11:26:39Z

    Reduce the coordination timeouts in TestZkLocalApplicationRunner tests.
    
    Changes in TestZkLocalApplicationRunner test timeout values:
    1. Change debounce timeout from 20 seconds to 2 seconds.
    2. Change task.shutdown timeout from 30 seconds to 5 seconds.
    3. Change barrier timeout from 40 seconds to 2 seonds.

----


---

[GitHub] samza pull request #537: SAMZA-1732: Reduce the coordination timeouts in Tes...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/537


---