You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (Created) (JIRA)" <ji...@apache.org> on 2012/02/16 21:02:59 UTC
[jira] [Created] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
FSTableDescriptors should handle random folders in hbase.root.dir better
------------------------------------------------------------------------
Key: HBASE-5415
URL: https://issues.apache.org/jira/browse/HBASE-5415
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Fix For: 0.94.0, 0.92.1
I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
{quote}
org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
{quote}
I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216337#comment-13216337 ]
Hudson commented on HBASE-5415:
-------------------------------
Integrated in HBase-TRUNK #2669 (See [https://builds.apache.org/job/HBase-TRUNK/2669/])
HBASE-5415 FSTableDescriptors should handle random folders in
hbase.root.dir better (Revision 1293042)
Result = SUCCESS
jdcryans :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/TableDescriptors.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215175#comment-13215175 ]
Jean-Daniel Cryans commented on HBASE-5415:
-------------------------------------------
bq. Whats difference between miscellaneous dirs under hbase.rootdir and an actual table directory that is missing its .tableinfo file?
Former's HTD is null, latter gets a FNFE.
bq. We're changing our API when we remove TEE from public methods?
Technically no, TEE (and FNFE FWIW) are both IOEs so there's no change there. I removed TEE specifically because it isn't thrown anymore.
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215259#comment-13215259 ]
stack commented on HBASE-5415:
------------------------------
+1 on commit
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215350#comment-13215350 ]
Hudson commented on HBASE-5415:
-------------------------------
Integrated in HBase-0.92 #301 (See [https://builds.apache.org/job/HBase-0.92/301/])
HBASE-5415 FSTableDescriptors should handle random folders in
hbase.root.dir better (Revision 1293041)
Result = SUCCESS
jdcryans :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/TableDescriptors.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Jean-Daniel Cryans (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-5415.
---------------------------------------
Resolution: Fixed
Assignee: Jean-Daniel Cryans
Hadoop Flags: Reviewed
Committed to branch and trunk, thanks for the review Stack.
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5415:
-------------------------
Priority: Critical (was: Major)
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.94.0, 0.92.1
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215164#comment-13215164 ]
stack commented on HBASE-5415:
------------------------------
Whats difference between miscellaneous dirs under hbase.rootdir and an actual table directory that is missing its .tableinfo file?
We're changing our API when we remove TEE from public methods?
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215252#comment-13215252 ]
Jean-Daniel Cryans commented on HBASE-5415:
-------------------------------------------
bq. I still don't understand how we can tell the different between a misc directory in wrong place and a table directory missing its .tableinfo. Both would look the same to the interrogating code I'd think?
I agree, so we used to send TEE and as you can see in the patch it never did anything special with it. Now we keep this behavior of printing something (a WARN) and then return null, which the rest of the code handles already.
bq. I mean, if I had client code that had a catch of a TEE, it'd stop working, right? (I'd doubt such a thing exists so I'm not too bad on removing this)
No, since you still have to catch the IOE somehow. Also it's not part of a public interface, only HMaster and HRegionServer use TableDescriptors
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215236#comment-13215236 ]
stack commented on HBASE-5415:
------------------------------
bq. Former's HTD is null, latter gets a FNFE.
I still don't understand how we can tell the different between a misc directory in wrong place and a table directory missing its .tableinfo. Both would look the same to the interrogating code I'd think?
bq. Technically no, TEE (and FNFE FWIW) are both IOEs so there's no change there. I removed TEE specifically because it isn't thrown anymore.
I mean, if I had client code that had a catch of a TEE, it'd stop working, right? (I'd doubt such a thing exists so I'm not too bad on removing this)
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215409#comment-13215409 ]
Hudson commented on HBASE-5415:
-------------------------------
Integrated in HBase-TRUNK-security #121 (See [https://builds.apache.org/job/HBase-TRUNK-security/121/])
HBASE-5415 FSTableDescriptors should handle random folders in
hbase.root.dir better (Revision 1293042)
Result = SUCCESS
jdcryans :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/TableDescriptors.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Jean-Daniel Cryans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-5415:
--------------------------------------
Attachment: HBASE-5415.patch
This patch handles it by just printing a WARN, the side effect is that this method doesn't throw TableExistsException anymore (which didn't make sense anyway) so I cleaned up a bunch of code.
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5415) FSTableDescriptors should handle
random folders in hbase.root.dir better
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222116#comment-13222116 ]
Hudson commented on HBASE-5415:
-------------------------------
Integrated in HBase-0.92-security #96 (See [https://builds.apache.org/job/HBase-0.92-security/96/])
HBASE-5415 FSTableDescriptors should handle random folders in
hbase.root.dir better (Revision 1293041)
Result = FAILURE
jdcryans :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/TableDescriptors.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
> FSTableDescriptors should handle random folders in hbase.root.dir better
> ------------------------------------------------------------------------
>
> Key: HBASE-5415
> URL: https://issues.apache.org/jira/browse/HBASE-5415
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Critical
> Fix For: 0.92.1, 0.94.0
>
> Attachments: HBASE-5415.patch
>
>
> I faked an upgrade on a test cluster using our dev data so I had to distcp the data between the two clusters, but after starting up and doing the migration and whatnot the web UI didn't show any table. The reason was in the master's log:
> {quote}
> org.apache.hadoop.hbase.TableExistsException: No descriptor for _distcp_logs_e0ehek
> at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:164)
> at org.apache.hadoop.hbase.util.FSTableDescriptors.getAll(FSTableDescriptors.java:182)
> at org.apache.hadoop.hbase.master.HMaster.getHTableDescriptors(HMaster.java:1554)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:364)
> at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1326)
> {quote}
> I don't think we need to show a full stack (just a WARN maybe), this shouldn't kill the request (still see tables in the web UI), and why is that a TableExistsException?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira