You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/27 21:24:33 UTC
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3511
to review the following change.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
This test was supposed to wait until the master had committed
a given operation, but in fact was only waiting until all of the
servers had _replicated_ the operation. In TSAN builds where things
ran slower, this caused it to be about 7% flaky.
The fix is to simply wait for the op to be committed, not just replicated.
With the fix, I looped it 100 times and it passed.
Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3511/1
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2051/
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Patch Set 1: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/2054/
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Patch Set 1:
A java test failed due to https://issues.apache.org/jira/browse/KUDU-1496 (unrelated)
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
This test was supposed to wait until the master had committed
a given operation, but in fact was only waiting until all of the
servers had _replicated_ the operation. In TSAN builds where things
ran slower, this caused it to be about 7% flaky.
The fix is to simply wait for the op to be committed, not just replicated.
With the fix, I looped it 100 times and it passed.
Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Reviewed-on: http://gerrit.cloudera.org:8080/3511
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mike Percy: Looks good to me, approved
Todd Lipcon: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No