[GitHub] [druid] pjain1 commented on pull request #9725: WIP: Fine grained config and state resources

[GitBox <gi...@apache.org>]

pjain1 commented on pull request #9725:
URL: https://github.com/apache/druid/pull/9725#issuecomment-620414026


   I looked at it high level and it looks good conceptually, I have two high level comments -
   1. Lets preserve backwards compatibility by introducing a config like `useFineGrainedPermissions` in AuthConfig class and inject it in State and Config resource filter. If this is true then use resource name from subclasses otherwise use `STATE` and `CONFIG`. This config will be _false_ by default.
   2. Lets rebase and remove the WIP tag to gather review comments.
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org