You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/12/30 10:13:29 UTC
[GitHub] [ignite] AMashenkov opened a new pull request #7215: IGNITE-12512:
Compact log and drop log level down to info for cancelled queries
AMashenkov opened a new pull request #7215: IGNITE-12512: Compact log and drop log level down to info for cancelled queries
URL: https://github.com/apache/ignite/pull/7215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] AMashenkov commented on a change in pull request #7215:
IGNITE-12512: Compact log and drop log level down to info for cancelled
queries
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #7215: IGNITE-12512: Compact log and drop log level down to info for cancelled queries
URL: https://github.com/apache/ignite/pull/7215#discussion_r361995228
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
##########
@@ -668,7 +668,17 @@ private void sendError(ClusterNode node, long qryReqId, Throwable err) {
GridQueryFailResponse msg = new GridQueryFailResponse(qryReqId, err);
if (node.isLocal()) {
- U.error(log, "Failed to run map query on local node.", err);
+ if (err instanceof QueryCancelledException) {
+ String errMsg = "Failed to run cancelled map query on local node: [localNodeId="
+ + node.id() + ", reqId=" + qryReqId + ']';
+
+ if (log.isDebugEnabled())
+ U.warn(log, errMsg, err);
Review comment:
Unfortunately stacktrace can't be printed in info\debug levels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7215:
IGNITE-12512: Compact log and drop log level down to info for cancelled
queries
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7215: IGNITE-12512: Compact log and drop log level down to info for cancelled queries
URL: https://github.com/apache/ignite/pull/7215#discussion_r361997256
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
##########
@@ -668,7 +668,17 @@ private void sendError(ClusterNode node, long qryReqId, Throwable err) {
GridQueryFailResponse msg = new GridQueryFailResponse(qryReqId, err);
if (node.isLocal()) {
- U.error(log, "Failed to run map query on local node.", err);
+ if (err instanceof QueryCancelledException) {
+ String errMsg = "Failed to run cancelled map query on local node: [localNodeId="
+ + node.id() + ", reqId=" + qryReqId + ']';
+
+ if (log.isDebugEnabled())
+ U.warn(log, errMsg, err);
Review comment:
Complicated =( But ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] asfgit closed pull request #7215: IGNITE-12512: Compact
log and drop log level down to info for cancelled queries
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #7215: IGNITE-12512: Compact log and drop log level down to info for cancelled queries
URL: https://github.com/apache/ignite/pull/7215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7215:
IGNITE-12512: Compact log and drop log level down to info for cancelled
queries
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7215: IGNITE-12512: Compact log and drop log level down to info for cancelled queries
URL: https://github.com/apache/ignite/pull/7215#discussion_r361992782
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java
##########
@@ -668,7 +668,17 @@ private void sendError(ClusterNode node, long qryReqId, Throwable err) {
GridQueryFailResponse msg = new GridQueryFailResponse(qryReqId, err);
if (node.isLocal()) {
- U.error(log, "Failed to run map query on local node.", err);
+ if (err instanceof QueryCancelledException) {
+ String errMsg = "Failed to run cancelled map query on local node: [localNodeId="
+ + node.id() + ", reqId=" + qryReqId + ']';
+
+ if (log.isDebugEnabled())
+ U.warn(log, errMsg, err);
Review comment:
Cannot realize why do we need to log at WARN level when debug is enabled? From the first glance looks strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services