You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2013/07/22 18:57:17 UTC

git commit: TS-2044: Avoid logging client running into DENY status infinitely

Updated Branches:
  refs/heads/master c79c1c143 -> e0d39f8e0


TS-2044: Avoid logging client running into DENY status infinitely

When Loging host is down, Loging client will call flush_to_orphan()
to clear send_list.

And then Loging client will retry to connect to host. Once the
connection established again, client_send() will be called and
Logging client will move to LOG_COLL_CLIENT_IDLE status.

If m_flow is equal to LOG_COLL_FLOW_DENY, there is no chance to
update m_flow to LOG_COLL_FLOW_ALLOW.

We should update m_flow to LOG_COLL_FLOW_ALLOW after clear send_list
in flush_to_orphan().


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/e0d39f8e
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/e0d39f8e
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/e0d39f8e

Branch: refs/heads/master
Commit: e0d39f8e05ed192fc6ab59e5d78e07f4309f4dbb
Parents: c79c1c1
Author: Yunkai Zhang <qi...@taobao.com>
Authored: Mon Jul 22 09:55:47 2013 -0700
Committer: James Peach <jp...@apache.org>
Committed: Mon Jul 22 09:57:08 2013 -0700

----------------------------------------------------------------------
 CHANGES                               | 3 +++
 proxy/logging/LogCollationClientSM.cc | 3 +++
 2 files changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e0d39f8e/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 6a15460..92ab609 100644
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,9 @@
 Changes with Apache Traffic Server 3.3.5
 
 
+  *) [TS-2044] Avoid logging client running into DENY status infinitely.
+    Author: Yunkai Zhang <qi...@taobao.com>
+
   *) [TS-2030] Build error with --enable-interim-cache on fedora19 x86_64.
     Author: bettydramit <b13621367396 at gmail dot com>
 

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e0d39f8e/proxy/logging/LogCollationClientSM.cc
----------------------------------------------------------------------
diff --git a/proxy/logging/LogCollationClientSM.cc b/proxy/logging/LogCollationClientSM.cc
index d816ac0..155e928 100644
--- a/proxy/logging/LogCollationClientSM.cc
+++ b/proxy/logging/LogCollationClientSM.cc
@@ -742,5 +742,8 @@ LogCollationClientSM::flush_to_orphan()
     m_log_host->orphan_write_and_delete(log_buffer);
   }
 
+  // Now send_list is empty, let's update m_flow to ALLOW status
+  Debug("log-coll", "[%d]client::client_send - m_flow = ALLOW", m_id);
+  m_flow = LOG_COLL_FLOW_ALLOW;
 }
 #endif // TS_MICRO