You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/05/06 10:06:16 UTC
Re: Review Request 19988: Enabled readability/todo rule for cpplint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19988/
-----------------------------------------------------------
(Updated May 6, 2014, 1:06 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Rebased to cpplint whitelist and split off libprocess change into its own review.
Bugs: MESOS-1181
https://issues.apache.org/jira/browse/MESOS-1181
Repository: mesos-git
Description
-------
Enabled readability/todo rule for cpplint, which covers the following:
'Missing username in TODO; it should look like "// TODO(my_username): Stuff."'
Used git blame to trace back the unaccredited TODOs, 3 to benh and 2 to bmahler.
bmahler's TODO in slave.cpp is already covered by one in messages.proto for ReregisterSlaveMessage, so I removed it.
Diffs (updated)
-----
src/exec/exec.cpp 346e39f
src/master/master.cpp c79fdaf
src/sched/sched.cpp 3684cfe
src/slave/slave.cpp 2a48266
support/mesos-style.py bd7dcdb
Diff: https://reviews.apache.org/r/19988/diff/
Testing (updated)
-------
Ran mesos-style.py over entire source base with readability/todo enabled.
$ support/mesos-style.py
Checking 424 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
Total errors found: 0
Thanks,
Adam B
Re: Review Request 19988: Enabled readability/todo rule for cpplint.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19988/#review42396
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21107, 19988]
All tests passed.
- Mesos ReviewBot
On May 6, 2014, 8:06 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19988/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 8:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1181
> https://issues.apache.org/jira/browse/MESOS-1181
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled readability/todo rule for cpplint, which covers the following:
> 'Missing username in TODO; it should look like "// TODO(my_username): Stuff."'
>
> Used git blame to trace back the unaccredited TODOs, 3 to benh and 2 to bmahler.
> bmahler's TODO in slave.cpp is already covered by one in messages.proto for ReregisterSlaveMessage, so I removed it.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 346e39f
> src/master/master.cpp c79fdaf
> src/sched/sched.cpp 3684cfe
> src/slave/slave.cpp 2a48266
> support/mesos-style.py bd7dcdb
>
> Diff: https://reviews.apache.org/r/19988/diff/
>
>
> Testing
> -------
>
> Ran mesos-style.py over entire source base with readability/todo enabled.
> $ support/mesos-style.py
> Checking 424 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
> Total errors found: 0
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19988: Enabled readability/todo rule for cpplint.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19988/#review42319
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On May 6, 2014, 1:06 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19988/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 1:06 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1181
> https://issues.apache.org/jira/browse/MESOS-1181
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enabled readability/todo rule for cpplint, which covers the following:
> 'Missing username in TODO; it should look like "// TODO(my_username): Stuff."'
>
> Used git blame to trace back the unaccredited TODOs, 3 to benh and 2 to bmahler.
> bmahler's TODO in slave.cpp is already covered by one in messages.proto for ReregisterSlaveMessage, so I removed it.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 346e39f
> src/master/master.cpp c79fdaf
> src/sched/sched.cpp 3684cfe
> src/slave/slave.cpp 2a48266
> support/mesos-style.py bd7dcdb
>
> Diff: https://reviews.apache.org/r/19988/diff/
>
>
> Testing
> -------
>
> Ran mesos-style.py over entire source base with readability/todo enabled.
> $ support/mesos-style.py
> Checking 424 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
> Total errors found: 0
>
>
> Thanks,
>
> Adam B
>
>