[GitHub] [iceberg] zhangjun0x01 commented on pull request #2508: Core : fix bugs in RewriteDataFilesAction when datafile size greater than targetFileSize

[GitBox <gi...@apache.org>]

zhangjun0x01 commented on pull request #2508:
URL: https://github.com/apache/iceberg/pull/2508#issuecomment-828118230


   the issues of test case in [PR 2196](https://github.com/apache/iceberg/pull/2196):
   
   We set the targetSizeInBytes to filesize of max filesize - 10, but there is no data in the last 10 bytes of this largest file, so in this case the largest file is not  split, and the newly generated file will be the same size as the original file. So I set targetSizeInBytes to half of the maximum file size, so this largest file will be split into two files, and finally three datafiles will be generated
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org