You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "David de L. (Jira)" <ji...@apache.org> on 2019/11/13 08:40:00 UTC
[jira] [Comment Edited] (AIRFLOW-3457) Refactor: Move User out of
models.py
[ https://issues.apache.org/jira/browse/AIRFLOW-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971140#comment-16971140 ]
David de L. edited comment on AIRFLOW-3457 at 11/13/19 8:39 AM:
----------------------------------------------------------------
[~ash] [~basph] [~fokko] why was `user.py` [removed|https://github.com/apache/airflow/blame/50343040ff4679e32e01f138ead80bc4bcef4b47/airflow/models/__init__.py#L38-L41] in `master`?
It is still used by multiple auth backends on `master` (there's also no mention of this is `UPDATING.md`):
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/kerberos_auth.py#L48]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/github_enterprise_auth.py#L38]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/google_auth.py#L38]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/ldap_auth.py#L127]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/password_auth.py#L54]
was (Author: ddelange):
[~ash] why was `user.py` [removed|https://github.com/apache/airflow/blame/50343040ff4679e32e01f138ead80bc4bcef4b47/airflow/models/__init__.py#L38-L41] in `master`?
It is still used by multiple auth backends on `master` (there's also no mention of this is `UPDATING.md`):
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/kerberos_auth.py#L48]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/github_enterprise_auth.py#L38]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/google_auth.py#L38]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/ldap_auth.py#L127]
[https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/contrib/auth/backends/password_auth.py#L54]
> Refactor: Move User out of models.py
> ------------------------------------
>
> Key: AIRFLOW-3457
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3457
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: models
> Affects Versions: 1.10.1
> Reporter: Fokko Driesprong
> Assignee: Bas Harenslak
> Priority: Major
> Fix For: 2.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)