You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/10/12 17:26:32 UTC
[kudu-CR] Remove column ids from KuduSchema::ToString
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11668
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Remove column ids from KuduSchema::ToString
708d0f736c5a9d60ca02041bdb3b753e11478b6d added a KuduSchema::ToString
method, which calls into Schema::ToString. This is fine except
Schema::ToString includes the column ids when they are set, and that
information is implementation and ought not be shown to the user.
I think the original testing missed this because it never called
KuduSchema::ToString on a KuduSchema built from a Schema that had column
ids. A new test fixes this oversight.
Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
5 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/11668/1
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Remove column ids from KuduSchema::ToString
708d0f736c5a9d60ca02041bdb3b753e11478b6d added a KuduSchema::ToString
method, which calls into Schema::ToString. This is fine except
Schema::ToString includes the column ids when they are set, and that
information is implementation and ought not be shown to the user.
I think the original testing missed this because it never called
KuduSchema::ToString on a KuduSchema built from a Schema that had column
ids. A new test fixes this oversight.
Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Reviewed-on: http://gerrit.cloudera.org:8080/11668
Tested-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
5 files changed, 49 insertions(+), 6 deletions(-)
Approvals:
Will Berkeley: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Patch Set 2: Verified+1
I think the failures are unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 20:01:29 +0000
Gerrit-HasComments: No
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11668/1/src/kudu/common/schema.h
File src/kudu/common/schema.h:
http://gerrit.cloudera.org:8080/#/c/11668/1/src/kudu/common/schema.h@735
PS1, Line 735: std::string ToString(ToStringMode mode = ToStringMode::WITH_COLUMN_IDS) const;
> Did you look at who else calls this? Seems like we might just want to chan
Skimming callers, it's mostly used for debug printing purposes (e.g. DCHECK_SCHEMA_EQUAL) where I think the column ids have real value.
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 19:59:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Fengling Wang, Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11668
to look at the new patch set (#2).
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Remove column ids from KuduSchema::ToString
708d0f736c5a9d60ca02041bdb3b753e11478b6d added a KuduSchema::ToString
method, which calls into Schema::ToString. This is fine except
Schema::ToString includes the column ids when they are set, and that
information is implementation and ought not be shown to the user.
I think the original testing missed this because it never called
KuduSchema::ToString on a KuduSchema built from a Schema that had column
ids. A new test fixes this oversight.
Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
5 files changed, 49 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/11668/2
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 21:19:17 +0000
Gerrit-HasComments: No
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11668/1/src/kudu/common/schema.h
File src/kudu/common/schema.h:
http://gerrit.cloudera.org:8080/#/c/11668/1/src/kudu/common/schema.h@735
PS1, Line 735: std::string ToString(ToStringMode mode = ToStringMode::WITH_COLUMN_IDS) const;
Did you look at who else calls this? Seems like we might just want to change the behavior for all cases?
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 12 Oct 2018 19:26:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] Remove column ids from KuduSchema::ToString
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11668 )
Change subject: Remove column ids from KuduSchema::ToString
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ib5999c485b63b6bdd4f4778b329f6768680b5193
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>