You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/22 06:47:58 UTC
[GitHub] [apisix-dashboard] qian0817 opened a new pull request #1816: Use monaco editor
qian0817 opened a new pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
1. Use monaco editor to highlight error line.
**Related issues**
fix/resolve #1040
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831982960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8323e66) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.50%`.
> The diff coverage is `62.16%`.
> :exclamation: Current head 8323e66 differs from pull request most recent head 7923fe0. Consider uploading reports for the commit 7923fe0 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.29% +0.50%
==========================================
Files 172 125 -47
Lines 6100 2956 -3144
Branches 713 712 -1
==========================================
- Hits 4379 2137 -2242
+ Misses 1478 819 -659
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.29% <62.16%> (+0.31%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <41.02%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.46% <66.66%> (+2.53%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <78.12%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.71% <100.00%> (+0.01%)` | :arrow_up: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| ... and [46 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...7923fe0](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit c177660a397df09163d92bb922280068eec28db2
https://app.netlify.com/sites/apisix-dashboard/deploys/60a39950beeb260007d080e8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630724524
##########
File path: web/package.json
##########
@@ -68,6 +67,7 @@
"js-yaml": "^4.0.0",
"lodash": "^4.17.11",
"moment": "^2.25.3",
+ "monaco-editor-webpack-plugin": "^3.0.1",
Review comment:
This dependency is used to `A plugin to simplify loading the Monaco Editor with webpack.` Maybe it belongs to `dev-dependencies`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit a307fe61d736e62e46b059ad897ff270516a97f9
https://app.netlify.com/sites/apisix-dashboard/deploys/608537f95db9d2000792d5ec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629394731
##########
File path: web/package.json
##########
@@ -68,6 +67,7 @@
"js-yaml": "^4.0.0",
"lodash": "^4.17.11",
"moment": "^2.25.3",
+ "monaco-editor-webpack-plugin": "^3.0.1",
Review comment:
If removed then monaco editor will not show highlighting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-841816299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824832778
@juzhiyuan
I have two questions about CI.
1. why netlify always run fail.
2. It seems like not have enough memory when yarn build, how to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f815253) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.22%`.
> The diff coverage is `36.73%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.01% +0.22%
==========================================
Files 172 125 -47
Lines 6100 2948 -3152
Branches 713 712 -1
==========================================
- Hits 4379 2123 -2256
+ Misses 1478 825 -653
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.01% <36.73%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `38.59% <24.13%> (+0.86%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.46% <55.00%> (+2.53%)` | :arrow_up: |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
| ... and [40 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...f815253](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831983979
~~ok I know what happened~~
Let me recheck in local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-833167386
Fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy Preview for *apisix-dashboard* processing.
Building with commit 84b419ffd2ce8a84c12bc34d7c30f809ac4bac0e
https://app.netlify.com/sites/apisix-dashboard/deploys/60a4a9f7d642ea00085b74c9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit c46fb025971884142ac9c6ca490cdba162527d0a
https://app.netlify.com/sites/apisix-dashboard/deploys/6090c58fa2f6570007959b30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b419f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9728a430193331d135da4fd5661cd4100308afbf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9728a43) will **decrease** coverage by `3.08%`.
> The diff coverage is `43.22%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
- Coverage 66.97% 63.88% -3.09%
==========================================
Files 169 122 -47
Lines 6314 3121 -3193
Branches 745 746 +1
==========================================
- Hits 4229 1994 -2235
+ Misses 1833 1127 -706
+ Partials 252 0 -252
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `63.88% <43.22%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | `1.47% <0.00%> (ø)` | |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `26.08% <19.35%> (-0.78%)` | :arrow_down: |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `67.58% <60.97%> (+1.36%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <100.00%> (ø)` | |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
| ... and [44 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9728a43...84b419f](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f486ed) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.54%`.
> The diff coverage is `62.39%`.
> :exclamation: Current head 3f486ed differs from pull request most recent head 041ece3. Consider uploading reports for the commit 041ece3 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.32% +0.54%
==========================================
Files 172 125 -47
Lines 6100 2956 -3144
Branches 713 711 -2
==========================================
- Hits 4379 2138 -2241
+ Misses 1478 818 -660
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.32% <62.39%> (+0.34%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
| [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `41.37% <ø> (ø)` | |
| [web/src/pages/Service/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvU3RlcDEudHN4) | `100.00% <ø> (ø)` | |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | `94.64% <66.66%> (-0.10%)` | :arrow_down: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.71% <67.56%> (+2.77%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (-1.30%)` | :arrow_down: |
| [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `81.69% <100.00%> (+0.26%)` | :arrow_up: |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <100.00%> (ø)` | |
| ... and [49 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...041ece3](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit f9c4bca96b2b5809d519d0e1b8554fd2a03e712f
https://app.netlify.com/sites/apisix-dashboard/deploys/60a0f22ac25d0e000842909c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630724729
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
No, I see this PR contains more than 3k+ changes 😳😳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831983979
ok I know what happened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9c4bca) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e14cb8c952ac854b15c9b5be27bebefa40d79165?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e14cb8c) will **increase** coverage by `0.11%`.
> The diff coverage is `58.47%`.
> :exclamation: Current head f9c4bca differs from pull request most recent head fa65afa. Consider uploading reports for the commit fa65afa to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 68.85% 68.97% +0.11%
==========================================
Files 122 122
Lines 3111 3123 +12
Branches 745 746 +1
==========================================
+ Hits 2142 2154 +12
Misses 969 969
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.97% <58.47%> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | `1.47% <0.00%> (ø)` | |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `67.58% <60.97%> (+1.36%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <100.00%> (ø)` | |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e14cb8c...fa65afa](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit e26fa5c150551ce405c14cb179ac19c4a475ee2d
https://app.netlify.com/sites/apisix-dashboard/deploys/60829933dc67d30007e8df48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629424618
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
I find it is a [bug](https://github.com/umijs/umi/issues/6398),I will update dependency version to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-841831731
> @juzhiyuan Hi, I need to ask when the command in netlify can modify and you can see that `Test building web in multiple node version` in github action run successfully.
>
> BTW, I don't know why it fails with npm install,it would be great if can solve this problem, But I can't deal with this issue by meself.
Afaik, its an issue from github action, let it get fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832904030
@juzhiyuan @qian0817
after having a search to those errors regarding jest,
we can give a try to this command after imports
`jest.useFakeTimers();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831787974
ok, just triggered to redeploy. Codes LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824862819
Wow, great, PR was submitted so soon.
But I have a question: why are there so many changes in `web/yarn.lock`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 945507e5f70311f986d553e72d563b564e97d9cf
https://app.netlify.com/sites/apisix-dashboard/deploys/60851a983842130007500bc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa65afa) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e14cb8c952ac854b15c9b5be27bebefa40d79165?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e14cb8c) will **increase** coverage by `0.18%`.
> The diff coverage is `58.47%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 68.85% 69.03% +0.18%
==========================================
Files 122 122
Lines 3111 3123 +12
Branches 745 746 +1
==========================================
+ Hits 2142 2156 +14
+ Misses 969 967 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `69.03% <58.47%> (+0.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | `1.47% <0.00%> (ø)` | |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `67.58% <60.97%> (+1.36%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <100.00%> (ø)` | |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e14cb8c...fa65afa](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit f0a8e4dca1b6fe911e04f85952c6ecb9fae21dd9
https://app.netlify.com/sites/apisix-dashboard/deploys/6098d813c4c78300076b1baa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (945507e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.56%`.
> The diff coverage is `52.23%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.35% +0.56%
==========================================
Files 172 125 -47
Lines 6100 2955 -3145
Branches 713 712 -1
==========================================
- Hits 4379 2138 -2241
+ Misses 1478 817 -661
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.35% <52.23%> (+0.37%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <29.03%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.46% <55.00%> (+2.53%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <93.75%> (+0.57%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | |
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
| [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | |
| ... and [44 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...945507e](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit fa65afac81f999aaf5f76284b2547d14eb97dc8d
https://app.netlify.com/sites/apisix-dashboard/deploys/60a0fa8bf73a640007b5c14d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 041ece3912df45eff04b7a2ac75a3f36eeecb86a
https://app.netlify.com/sites/apisix-dashboard/deploys/6090c646ba48990008be5506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e0f7cb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.55%`.
> The diff coverage is `59.13%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.34% +0.55%
==========================================
Files 172 125 -47
Lines 6100 2958 -3142
Branches 713 711 -2
==========================================
- Hits 4379 2140 -2239
+ Misses 1478 818 -660
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.34% <59.13%> (+0.36%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `64.78% <60.97%> (+1.85%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `78.80% <77.41%> (+1.66%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (-1.30%)` | :arrow_down: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | `94.64% <0.00%> (-0.10%)` | :arrow_down: |
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | |
| ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...9e0f7cb](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-836261267
@juzhiyuan Do I still need to make changes to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826956482
Hi, @qian0817 I find that when editing a created plugin on the plugin list page, the data is lost.
1. Created plugins
2. Change and save
3. Data lost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r620414773
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -14,34 +14,34 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import React, { useEffect, useRef, useState } from 'react';
+import React, { useEffect, useState } from 'react';
import {
+ Alert,
Button,
+ Divider,
+ Drawer,
+ Form,
+ Input,
notification,
PageHeader,
- Switch,
- Form,
+ Popconfirm,
Select,
- Divider,
- Drawer,
- Alert,
Space,
- Popconfirm,
- Tooltip,
- Input,
+ Switch,
} from 'antd';
import { useIntl } from 'umi';
-import CodeMirror from '@uiw/react-codemirror';
import { js_beautify } from 'js-beautify';
import { LinkOutlined } from '@ant-design/icons';
import Ajv from 'ajv';
import type { DefinedError } from 'ajv';
import addFormats from 'ajv-formats';
import { fetchSchema } from './service';
-import { json2yaml, yaml2json } from '../../helpers';
+import { json2yaml, yaml2json } from '@/helpers';
import { PluginForm, PLUGIN_UI_LIST } from './UI';
import { PluginType } from './data';
+import MonacoEditor from "react-monaco-editor";
+import type * as monacoEditor from "monaco-editor";
Review comment:
These two lines seem to go on line 38
##########
File path: web/src/pages/Route/components/DebugViews/DebugDrawView.tsx
##########
@@ -27,18 +26,20 @@ import { CopyOutlined } from "@ant-design/icons";
import PanelSection from '@/components/PanelSection';
import {
- HTTP_METHOD_OPTION_LIST,
- DEFAULT_DEBUG_PARAM_FORM_DATA,
- DEFAULT_DEBUG_AUTH_FORM_DATA,
- PROTOCOL_SUPPORTED,
+ DEBUG_BODY_MODE_SUPPORTED,
DEBUG_BODY_TYPE_SUPPORTED,
- DEBUG_BODY_CODEMIRROR_MODE_SUPPORTED,
- DEBUG_RESPONSE_BODY_CODEMIRROR_MODE_SUPPORTED,
+ DEBUG_RESPONSE_BODY_MODE_SUPPORTED,
DebugBodyFormDataValueType,
+ DEFAULT_DEBUG_AUTH_FORM_DATA,
+ DEFAULT_DEBUG_PARAM_FORM_DATA,
+ HTTP_METHOD_OPTION_LIST,
+ PROTOCOL_SUPPORTED,
} from '../../constants';
-import { DebugParamsView, AuthenticationView, DebugFormDataView } from '.';
+import { AuthenticationView, DebugFormDataView, DebugParamsView } from '.';
import { debugRoute } from '../../service';
import styles from './index.less';
+import MonacoEditor from "react-monaco-editor";
+import type * as monacoEditor from "monaco-editor";
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit f0a8e4dca1b6fe911e04f85952c6ecb9fae21dd9
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit ee3b144b9417f4e2faf1a12868a07a8e46d1bc6e
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629424618
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
~~I find it is a [bug](https://github.com/umijs/umi/issues/6398),I will update dependency version to fix it.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826512410
also cc @guoqqqi to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832529035
@juzhiyuan use `yarn install; yarn build` instead of `npm install; npm run build` to make netlify stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826512410
also cc @guoqqqi to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 9e0f7cbbda126e23d67ef8b811174a647e1bc71b
https://app.netlify.com/sites/apisix-dashboard/deploys/6090d3732a09cd00076cb998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831384729
Cool! Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit efa47210dad05ec7fcc4562ed705aff92a4b9749
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit ee3b144b9417f4e2faf1a12868a07a8e46d1bc6e
https://app.netlify.com/sites/apisix-dashboard/deploys/609b7a0d834af1000852ce57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832631584
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 7923fe0c45f691a507403c5c472cd1dbc5f22dc9
https://app.netlify.com/sites/apisix-dashboard/deploys/60856bd88b9be700071c5515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit fb62aaed616fe8e6aad0f72f88302d01ffe9c65d
https://app.netlify.com/sites/apisix-dashboard/deploys/609ab02cad026e0008aedccf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-845069413
I will re-implement the feature to make the netlify deployment successful and submit a new PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy Preview for *apisix-dashboard* processing.
Building with commit f3e7cba38340dfdb9d1e3310de6234f01e1a0a1f
https://app.netlify.com/sites/apisix-dashboard/deploys/60a49cd9f6b121000751e04d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c43265f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.47%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.25% +0.47%
==========================================
Files 172 125 -47
Lines 6100 2956 -3144
Branches 713 712 -1
==========================================
- Hits 4379 2136 -2243
+ Misses 1478 820 -658
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.25% <62.16%> (+0.27%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <41.02%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.46% <66.66%> (+2.53%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <78.12%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.43% <100.00%> (-1.27%)` | :arrow_down: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | |
| ... and [49 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...c43265f](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy Preview for *apisix-dashboard* processing.
Building with commit c9920bd47f0538a0898b4acac57e1c8104f9d0ff
https://app.netlify.com/sites/apisix-dashboard/deploys/60a490ba36135a0008d9e1c0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-833160594
> > @juzhiyuan @qian0817
>
> > after having a search to those errors regarding jest,
>
> > we can give a try to this command after imports
>
> > `jest.useFakeTimers();`
>
>
>
> Hi, may I know which error you mean? If this PR's changes look good to you?
Else the changes done are good , have reviewed them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629386504
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
Ant Design Pro contains UmiJS, and it will handle Webpack configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit c177660a397df09163d92bb922280068eec28db2
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832904030
@juzhiyuan
after having a search to those errors regarding jest,
we can give a try to this command after imports
`jest.useFakeTimers();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 closed pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 closed pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit dca90b7ebd983fa4023f3b8a4bfa1869afcbdca5
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832622927
noted, I will give a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629393048
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
But if I remove the webpack dependency then it will throw an error in `yarn install`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832529035
@juzhiyuan I guess using `yarn install; yarn build` instead of `npm install; npm run build` to make netlify stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 82933979330ff234b9dc20c2e3b7812e178323ec
https://app.netlify.com/sites/apisix-dashboard/deploys/60910c857f4e92048dd9abc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit c43265f2680f94ac53d2113e8126fe5a64d9fc5c
https://app.netlify.com/sites/apisix-dashboard/deploys/608642354651270007e4a48b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 077cafff54d1d6e68d39db27c3682e37fab7c136
https://app.netlify.com/sites/apisix-dashboard/deploys/609b70bbb7933100072c2652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-841831731
> @juzhiyuan Hi, I need to ask when the command in netlify can modify and you can see that `Test building web in multiple node version` in github action run successfully.
>
> BTW, I don't know why it fails with npm install,it would be great if can solve this problem, But I can't deal with this issue by meself.
Afaik, its an issue from github action, let it get fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1816: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 657a87c64b454761fe2ff32a49b5e18976092ee6
https://app.netlify.com/sites/apisix-dashboard/deploys/60811c1817ee0a000706cd2a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit bb590ac58dd5af1bc82a020115aa21f199a9337a
https://app.netlify.com/sites/apisix-dashboard/deploys/608794c91b69160008ff1b43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832623680
BTW, cc @iamayushdas @stu01509 to have a review when you have time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629385785
##########
File path: web/package.json
##########
@@ -68,6 +67,7 @@
"js-yaml": "^4.0.0",
"lodash": "^4.17.11",
"moment": "^2.25.3",
+ "monaco-editor-webpack-plugin": "^3.0.1",
Review comment:
🤔 Why we need this plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit f8152530d8676da15241d306ddb6e1ec79e75ded
https://app.netlify.com/sites/apisix-dashboard/deploys/6083b9dbe91bf90008b518dc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824886405
> Wow, great, PR was submitted so soon.
>
> But I have a question: why are there so many changes in `web/yarn.lock`?
I can't start after adding the monaco-editor-webpack-plugin dependency, it looks like having a breaking api used by dependencies. So I regenerate the yarn.lock file and It works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit e5b98bbac8e0991619771d0d05e05a4e7cafcab1
https://app.netlify.com/sites/apisix-dashboard/deploys/608282c6b4606f00079aa3e6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 99984cad19eb0f894c69b9434578d07599c7ce13
https://app.netlify.com/sites/apisix-dashboard/deploys/609b45e6c5dba30008bcc781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c36b4a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a58ed292ec6cc58d0750365deaa1b429d7d62103?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a58ed29) will **increase** coverage by `0.05%`.
> The diff coverage is `58.47%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 68.91% 68.97% +0.05%
==========================================
Files 122 122
Lines 3111 3123 +12
Branches 745 746 +1
==========================================
+ Hits 2144 2154 +10
- Misses 967 969 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.97% <58.47%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | `1.47% <0.00%> (ø)` | |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `67.58% <60.97%> (+1.36%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <100.00%> (ø)` | |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `85.88% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a58ed29...7c36b4a](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 8323e665fe6d61963033da769b4ff6b87ada8e37
https://app.netlify.com/sites/apisix-dashboard/deploys/608565fe1901ae0007b8091b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630696092
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
Is there a convenient way to divide PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r629841937
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
@juzhiyuan I find this bug was not fully fixed in the latest release and i reported the [issue](https://github.com/umijs/umi/issues/6551).need to wait for the next release of umi.So it needs to be fixed later in a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r625496911
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
yes, need to include webpack here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-833151114
> @juzhiyuan @qian0817
> after having a search to those errors regarding jest,
> we can give a try to this command after imports
> `jest.useFakeTimers();`
Hi, may I know which error you mean? If this PR's changes look good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 9a8db7bfddaab0d9ae133aae4ff13675cff69276
https://app.netlify.com/sites/apisix-dashboard/deploys/60816b84a05796000857a381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-845069413
I will re-implement the function to make the netlify deployment successful and submit a new PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-827306941
@guoqqqi fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit bd1ec32ac21219a7aeeaddd753ab8da1fa00bd54
https://app.netlify.com/sites/apisix-dashboard/deploys/6099021777841a00075ecb1c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r625377805
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
Do we need to maintain webpack manually here?
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -190,49 +188,53 @@ const PluginDetail: React.FC<Props> = ({
});
});
};
- const handleModeChange = (value: PluginComponent.CodeMirrorMode) => {
+
+ const editorWillMount = (monaco: typeof monacoEditor) => {
+ fetchSchema(name, schemaType).then((schema)=> {
+ const schemaConfig = {
+ validate: true,
+ schemas: [
+ {
+ uri: `https://apisix.apache.org/`,
Review comment:
May I know what's this opinion does?
##########
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##########
@@ -33,77 +33,66 @@ type Props = {
onSubmit?: (data: Record<string, any>) => void;
};
-enum codeMirrorModeList {
+enum monacoLanguageList {
JSON = 'JSON',
YAML = 'YAML',
}
const RawDataEditor: React.FC<Props> = ({ visible, readonly = true, type, data = {}, onClose = () => { }, onSubmit = () => { } }) => {
- const ref = useRef<any>(null);
const { formatMessage } = useIntl();
- const [codeMirrorMode, setCodeMirrorMode] = useState<PluginComponent.CodeMirrorMode>(
- codeMirrorModeList.JSON,
+ const [monacoLanguage, setMonacoLanguage] = useState<PluginComponent.MonacoLanguage>(
+ monacoLanguageList.JSON,
);
+ const [content, setContent] = useState('')
useEffect(() => {
- setCodeMirrorMode(codeMirrorModeList.JSON);
+ switch (monacoLanguage) {
+ case monacoLanguageList.JSON:
+ setContent(JSON.stringify(data, null, 4));
+ break;
+ case monacoLanguageList.YAML: {
+ const {data: yamlData} = json2yaml(JSON.stringify(data, null, 4));
+ setContent(yamlData)
+ break;
+ }
+ default:
+ }
+ }, [data])
+
+ useEffect(() => {
+ setMonacoLanguage(monacoLanguageList.JSON);
}, [visible])
const modeOptions = [
- { label: codeMirrorModeList.JSON, value: codeMirrorModeList.JSON },
- { label: codeMirrorModeList.YAML, value: codeMirrorModeList.YAML },
+ { label: monacoLanguageList.JSON, value: monacoLanguageList.JSON },
+ { label: monacoLanguageList.YAML, value: monacoLanguageList.YAML },
];
- const handleModeChange = (value: PluginComponent.CodeMirrorMode) => {
+ const handleModeChange = (value: PluginComponent.MonacoLanguage) => {
switch (value) {
- case codeMirrorModeList.JSON: {
- const { data: yamlData, error } = yaml2json(ref.current.editor.getValue(), true);
-
- if (error) {
- notification.error({
- message: 'Invalid Yaml data',
- });
- return;
- }
- ref.current.editor.setValue(
- js_beautify(yamlData, {
- indent_size: 2,
- }),
- );
+ case monacoLanguageList.JSON:
+ setContent(c => {
+ const {data:jsonData,error} = yaml2json(c, true);
+ if (error){
+ notification.error({message: 'Invalid Yaml data'});
+ return c;
+ }
+ return js_beautify(jsonData, {indent_size: 4});
+ })
break;
- }
- case codeMirrorModeList.YAML: {
- const { data: jsonData, error } = json2yaml(ref.current.editor.getValue());
-
- if (error) {
- notification.error({
- message: 'Invalid JSON data',
- });
- return;
- }
- ref.current.editor.setValue(jsonData);
+ case monacoLanguageList.YAML:
+ setContent(c => {
+ const {data:yamlData,error} = json2yaml(c);
+ if (error){
+ notification.error({message: 'Invalid Json data'});
Review comment:
ditto
##########
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##########
@@ -33,77 +33,66 @@ type Props = {
onSubmit?: (data: Record<string, any>) => void;
};
-enum codeMirrorModeList {
+enum monacoLanguageList {
JSON = 'JSON',
YAML = 'YAML',
}
const RawDataEditor: React.FC<Props> = ({ visible, readonly = true, type, data = {}, onClose = () => { }, onSubmit = () => { } }) => {
- const ref = useRef<any>(null);
const { formatMessage } = useIntl();
- const [codeMirrorMode, setCodeMirrorMode] = useState<PluginComponent.CodeMirrorMode>(
- codeMirrorModeList.JSON,
+ const [monacoLanguage, setMonacoLanguage] = useState<PluginComponent.MonacoLanguage>(
+ monacoLanguageList.JSON,
);
+ const [content, setContent] = useState('')
useEffect(() => {
- setCodeMirrorMode(codeMirrorModeList.JSON);
+ switch (monacoLanguage) {
+ case monacoLanguageList.JSON:
+ setContent(JSON.stringify(data, null, 4));
+ break;
+ case monacoLanguageList.YAML: {
+ const {data: yamlData} = json2yaml(JSON.stringify(data, null, 4));
+ setContent(yamlData)
+ break;
+ }
+ default:
+ }
+ }, [data])
+
+ useEffect(() => {
+ setMonacoLanguage(monacoLanguageList.JSON);
}, [visible])
const modeOptions = [
- { label: codeMirrorModeList.JSON, value: codeMirrorModeList.JSON },
- { label: codeMirrorModeList.YAML, value: codeMirrorModeList.YAML },
+ { label: monacoLanguageList.JSON, value: monacoLanguageList.JSON },
+ { label: monacoLanguageList.YAML, value: monacoLanguageList.YAML },
];
- const handleModeChange = (value: PluginComponent.CodeMirrorMode) => {
+ const handleModeChange = (value: PluginComponent.MonacoLanguage) => {
switch (value) {
- case codeMirrorModeList.JSON: {
- const { data: yamlData, error } = yaml2json(ref.current.editor.getValue(), true);
-
- if (error) {
- notification.error({
- message: 'Invalid Yaml data',
- });
- return;
- }
- ref.current.editor.setValue(
- js_beautify(yamlData, {
- indent_size: 2,
- }),
- );
+ case monacoLanguageList.JSON:
+ setContent(c => {
+ const {data:jsonData,error} = yaml2json(c, true);
+ if (error){
+ notification.error({message: 'Invalid Yaml data'});
Review comment:
We need to add `i18n` for those untranslated tips 😊
##########
File path: web/cypress/integration/consumer/create-consumer-with-api-breaker-plugin-form.spec.js
##########
@@ -50,17 +50,13 @@ context('Create and delete consumer with api-breaker plugin form', () => {
});
cy.focused(this.domSelector.drawer).should('exist');
cy.get(this.domSelector.disabledSwitcher).click();
- // edit codemirror
- cy.get(this.domSelector.codeMirror)
- .first()
- .then((editor) => {
- editor[0].CodeMirror.setValue(
- JSON.stringify({
- key: 'test',
- }),
- );
- cy.contains('button', 'Submit').click();
- });
+ // edit
+ cy.window().then(({ monaco }) => {
+ if (monaco) {
+ monaco.setValue(JSON.stringify({ key: 'test' }));
Review comment:
What about if `monaco` doesn't exist?
##########
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##########
@@ -33,77 +33,66 @@ type Props = {
onSubmit?: (data: Record<string, any>) => void;
};
-enum codeMirrorModeList {
+enum monacoLanguageList {
JSON = 'JSON',
YAML = 'YAML',
}
const RawDataEditor: React.FC<Props> = ({ visible, readonly = true, type, data = {}, onClose = () => { }, onSubmit = () => { } }) => {
- const ref = useRef<any>(null);
const { formatMessage } = useIntl();
- const [codeMirrorMode, setCodeMirrorMode] = useState<PluginComponent.CodeMirrorMode>(
- codeMirrorModeList.JSON,
+ const [monacoLanguage, setMonacoLanguage] = useState<PluginComponent.MonacoLanguage>(
+ monacoLanguageList.JSON,
);
+ const [content, setContent] = useState('')
useEffect(() => {
- setCodeMirrorMode(codeMirrorModeList.JSON);
+ switch (monacoLanguage) {
+ case monacoLanguageList.JSON:
+ setContent(JSON.stringify(data, null, 4));
Review comment:
```suggestion
setContent(JSON.stringify(data, null, 2));
```
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -190,49 +188,53 @@ const PluginDetail: React.FC<Props> = ({
});
});
};
- const handleModeChange = (value: PluginComponent.CodeMirrorMode) => {
+
+ const editorWillMount = (monaco: typeof monacoEditor) => {
+ fetchSchema(name, schemaType).then((schema)=> {
+ const schemaConfig = {
+ validate: true,
+ schemas: [
+ {
+ uri: `https://apisix.apache.org/`,
+ fileMatch: ['*'],
+ schema
+ }
+ ]
+ };
+ monaco.languages.json.jsonDefaults.setDiagnosticsOptions(schemaConfig);
+ })
+ }
+
+ const handleModeChange = (value: PluginComponent.MonacoLanguage) => {
switch (value) {
- case codeMirrorModeList.JSON: {
- if (codeMirrorMode === codeMirrorModeList.YAML) {
- const { data: yamlData, error } = yaml2json(ref.current.editor.getValue(), true);
+ case monacoModeList.JSON: {
+ if (monacoMode === monacoModeList.YAML) {
+ const { data: yamlData, error } = yaml2json(content, true);
if (error) {
notification.error({
message: 'Invalid Yaml data',
});
return;
}
- ref.current.editor.setValue(
- js_beautify(yamlData, {
- indent_size: 2,
- }),
- );
+ setContent(js_beautify(yamlData, { indent_size: 4 }))
} else {
- ref.current.editor.setValue(
- js_beautify(JSON.stringify(getUIFormData()), {
- indent_size: 2,
- }),
- );
+ setContent(js_beautify(JSON.stringify(getUIFormData()), { indent_size: 4 }))
Review comment:
We use 2 spaces for JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-841816299
@juzhiyuan Hi, I need to ask when the command in netlify can modify and you can see that `Test building web in multiple node version` in github action run successfully.
BTW, I don't know why it fails with npm install,it would be great if can solve this problem, But I can't deal with this issue by meself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824886405
> Wow, great, PR was submitted so soon.
>
> But I have a question: why are there so many changes in `web/yarn.lock`?
Because when i start use
> Wow, great, PR was submitted so soon.
>
> But I have a question: why are there so many changes in `web/yarn.lock`?
I can't start after adding the monaco-editor-webpack-plugin dependency, it looks like having a breaking api used by dependencies. So I regenerate the yarn.lock file and It works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831868630
> ok, just triggered to redeploy. Codes LGTM
@juzhiyuan Still failing to deploy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* failed.
Built with commit 077cafff54d1d6e68d39db27c3682e37fab7c136
https://app.netlify.com/sites/apisix-dashboard/deploys/609b70bbb7933100072c2652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630749474
##########
File path: web/package.json
##########
@@ -68,6 +67,7 @@
"js-yaml": "^4.0.0",
"lodash": "^4.17.11",
"moment": "^2.25.3",
+ "monaco-editor-webpack-plugin": "^3.0.1",
Review comment:
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630750023
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
Most of the changes are change of yarn.lock . the actual number of lines changed is about 800.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit bb590ac58dd5af1bc82a020115aa21f199a9337a
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6cdefb0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a58ed292ec6cc58d0750365deaa1b429d7d62103?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a58ed29) will **increase** coverage by `0.11%`.
> The diff coverage is `58.47%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 68.91% 69.03% +0.11%
==========================================
Files 122 122
Lines 3111 3123 +12
Branches 745 746 +1
==========================================
+ Hits 2144 2156 +12
Misses 967 967
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `69.03% <58.47%> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/PluginFlow/PluginFlow.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbkZsb3cvUGx1Z2luRmxvdy50c3g=) | `1.47% <0.00%> (ø)` | |
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `67.58% <60.97%> (+1.36%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (ø)` | |
| [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <100.00%> (ø)` | |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `85.88% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a58ed29...6cdefb0](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8293397) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.49%`.
> The diff coverage is `59.13%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.27% +0.49%
==========================================
Files 172 125 -47
Lines 6100 2958 -3142
Branches 713 711 -2
==========================================
- Hits 4379 2138 -2241
+ Misses 1478 820 -658
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.27% <59.13%> (+0.29%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `64.78% <60.97%> (+1.85%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (-1.30%)` | :arrow_down: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | `94.64% <0.00%> (-0.10%)` | :arrow_down: |
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
| ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...8293397](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 82933979330ff234b9dc20c2e3b7812e178323ec
https://app.netlify.com/sites/apisix-dashboard/deploys/6090ebadfaf7d40007d75d6c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit bef031ab4acfa49fb820f63d8c01c74ffd71bb7d
https://app.netlify.com/sites/apisix-dashboard/deploys/6091126f8fe216000793fb8b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* ready!
Built with commit c43265f2680f94ac53d2113e8126fe5a64d9fc5c
https://deploy-preview-1816--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f815253) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.22%`.
> The diff coverage is `36.73%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.01% +0.22%
==========================================
Files 172 125 -47
Lines 6100 2948 -3152
Branches 713 712 -1
==========================================
- Hits 4379 2123 -2256
+ Misses 1478 825 -653
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.01% <36.73%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `38.59% <24.13%> (+0.86%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.46% <55.00%> (+2.53%)` | :arrow_up: |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
| ... and [40 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...f815253](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7923fe0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.50%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.29% +0.50%
==========================================
Files 172 125 -47
Lines 6100 2956 -3144
Branches 713 712 -1
==========================================
- Hits 4379 2137 -2242
+ Misses 1478 819 -659
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.29% <62.16%> (+0.31%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <41.02%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.46% <66.66%> (+2.53%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <78.12%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.71% <100.00%> (+0.01%)` | :arrow_up: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | |
| ... and [46 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...7923fe0](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit d7ed82a4c9d836f7f21151f5da4ee7bd0f79b17e
https://app.netlify.com/sites/apisix-dashboard/deploys/609cb57f326a64000719f484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit efa47210dad05ec7fcc4562ed705aff92a4b9749
https://app.netlify.com/sites/apisix-dashboard/deploys/608546f43842130007521faa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1816](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dca90b7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45908018abf258cc303cca46ffbab60bbd2a837b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4590801) will **increase** coverage by `0.42%`.
> The diff coverage is `59.13%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 71.78% 72.21% +0.42%
==========================================
Files 172 125 -47
Lines 6100 2958 -3142
Branches 713 711 -2
==========================================
- Hits 4379 2136 -2243
+ Misses 1478 822 -656
+ Partials 243 0 -243
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `72.21% <59.13%> (+0.22%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `40.67% <40.00%> (+2.94%)` | :arrow_up: |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `64.78% <60.97%> (+1.85%)` | :arrow_up: |
| [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `77.71% <77.41%> (+0.57%)` | :arrow_up: |
| [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.40% <100.00%> (-1.30%)` | :arrow_down: |
| [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (-3.28%)` | :arrow_down: |
| [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | `94.64% <0.00%> (-0.10%)` | :arrow_down: |
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1816/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590801...dca90b7](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-831735929
@juzhiyuan It throws an error when running `npm run build` during Netlify deployment, but it works fine on my local machine. Can you help me point out where is wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630037341
##########
File path: web/package.json
##########
@@ -131,7 +132,8 @@
"prettier": "^2.0.1",
"pro-download": "1.0.1",
"puppeteer-core": "^4.0.1",
- "stylelint": "^13.0.0"
+ "stylelint": "^13.0.0",
+ "webpack": "^5.35.0"
Review comment:
ok, BTW, the current PR is too large to review 🤣🤣 Could we split into some smaller ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r625499416
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -190,49 +188,53 @@ const PluginDetail: React.FC<Props> = ({
});
});
};
- const handleModeChange = (value: PluginComponent.CodeMirrorMode) => {
+
+ const editorWillMount = (monaco: typeof monacoEditor) => {
+ fetchSchema(name, schemaType).then((schema)=> {
+ const schemaConfig = {
+ validate: true,
+ schemas: [
+ {
+ uri: `https://apisix.apache.org/`,
Review comment:
This uri seems like useless if the schema is already set, but this is required by type and must be a valid uri. So I just use `https://apisix.apache.org` as a placeholder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 7c36b4a61931c32d29ce717e931d56bbb2a116ee
https://app.netlify.com/sites/apisix-dashboard/deploys/609bad42eef20b00079eb329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit dca90b7ebd983fa4023f3b8a4bfa1869afcbdca5
https://app.netlify.com/sites/apisix-dashboard/deploys/609256586ae5b800083efc8e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
qian0817 commented on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-841832495
> > @juzhiyuan Hi, I need to ask when the command in netlify can modify and you can see that `Test building web in multiple node version` in github action run successfully.
> > BTW, I don't know why it fails with npm install,it would be great if can solve this problem, But I can't deal with this issue by meself.
>
> Afaik, its an issue from github action, let it get fixed.
I am not referring to the current problem with github action but to [the problem of using the wrong command in netlify](https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-832529035).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997
Deploy preview for *apisix-dashboard* processing.
Building with commit 6cdefb0123c01aa39501ec13ec7449bb667841d1
https://app.netlify.com/sites/apisix-dashboard/deploys/609cf68f9be80e0007880e8e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org