You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/02/27 18:53:25 UTC
[GitHub] [accumulo] milleruntime opened a new issue #1535: Investigate empty
files in Major Compactions
milleruntime opened a new issue #1535: Investigate empty files in Major Compactions
URL: https://github.com/apache/accumulo/issues/1535
I noticed while working on #1519 that if a Major compaction produces an empty file that it will still be added to the list of majorCompactingFiles. This happens [here](https://github.com/apache/accumulo/blob/1.9/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L596). This is different from the rest of the code which checks if ```DataFileValue.getNumEntries() > 0```. This file will be deleted towards the beginning of ```bringMajorCompactionOnline()``` [here](https://github.com/apache/accumulo/blob/1.9/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L541). The list files is cleared at the end of the MajC but there parts of the code which check the size of the list that this could effect.
If there is no reason why we care about an empty file that is already deleted, then this is a bug and the file shouldn't be added to the list.
The place were this file is deleted for MajC also seems sub-optimal since we are renaming the file immediately before removing it. Minor compactions will do one or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] milleruntime closed issue #1535: Investigate empty files
in Major Compactions
Posted by GitBox <gi...@apache.org>.
milleruntime closed issue #1535: Investigate empty files in Major Compactions
URL: https://github.com/apache/accumulo/issues/1535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services